damencs / tob-qol

OSRS: Theatre of Blood Quality of Life Enhancement Features for RuneLite External Plugin Hub
BSD 2-Clause "Simplified" License
0 stars 6 forks source link

Checkbox to optionally leave npc highlighting during death animation #1

Open JeremyReynold opened 2 years ago

JeremyReynold commented 2 years ago

Would it be possible to add a checkbox which would allow to keep highlighting during death animation for bigs in nylocas room?

damencs commented 2 years ago

Would it be possible to add a checkbox which would allow to keep highlighting during death animation for bigs in nylocas room?

@JeremyReynold - I would think this would fall under the guideline of: "Indicates the time where a boss mechanic may start or end" and "Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper".

JeremyReynold commented 2 years ago

Would it be possible to add a checkbox which would allow to keep highlighting during death animation for bigs in nylocas room?

@JeremyReynold - I would think this would fall under the guideline of: "Indicates the time where a boss mechanic may start or end" and "Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper".

Maybe it is a slipy edge, but this indicator is present in vanilla as well. Whenever the big death animation ends, splits pop up. We would not be marking a square and a tick counter which would show when the splits are coming out (as it used to be in other 3rd party clients) but rather leave the highlighting for death animation of a NPC.

damencs commented 2 years ago

@JeremyReynold - I will add it as a config item to be able to keep the tile marked until the NPC is fully removed from the client's cached npc's (essentially removing the check for whether or not it's dead).

JeremyReynold commented 2 years ago

Currently this is possible with better npc indicators. But that means that you can't use that plugin for anything else if you want to keep highlighting off during death animation.