search

damiafuentes / DJITelloPy

DJI Tello drone python interface using the official Tello SDK. Feel free to contribute!
MIT License
1.26k stars 491 forks source link

Merge not included in pip build #147

Open NikEyX opened 2 years ago

NikEyX commented 2 years ago

With so many people complaining about the video lagging, I was wondering why this library still uses OpenCV for capture. Then I saw in the commits that OpenCV HAS been replaced by PyAV in one of the PRs: https://github.com/damiafuentes/DJITelloPy/pull/120

And yet, the version on pip does not contain this change? It does, however, contain the chinese language change that came AFTER this PR???

Perhaps it would make sense to update the pip version to the current version on github?

M4GNV5 commented 2 years ago

Ahh interesting, i didnt realise the pyAV parts are not released to pypi yet, i was already wondering because of issue #145.

To me it does not look like the chinese language changes are released yet either. Neither the readme on pypi nor the readme in the source distribution download includes the chinese version.

If i recall correctly i was afraid the pyAV change might cause more problems which have not been discovered yet, but i assume by now we can just release it to pypi.