Wrong frame size in documentation

damiafuentes / DJITelloPy

DJI Tello drone python interface using the official Tello SDK. Feel free to contribute!

MIT License

1.21k stars 479 forks source link

Wrong frame size in documentation #213

Open irudnyts opened 7 months ago

irudnyts commented 7 months ago

I noticed that the frame is actually 960x720, rather than 1080x720, as it is written here:

import pygame
from djitellopy import Tello

drone = Tello()
drone.connect()
drone.streamon()

frame_read = drone.get_frame_read()
print(frame_read.frame.shape)

drone.streamoff()

This is just typo, right?

M4GNV5 commented 7 months ago

Yes seems like a typo. Maybe the camera can do photos in 1080x720, but i guess we can still change the text to the correct format. Fell free to send a pull request!

irudnyts commented 7 months ago

Will do. One more thing, I noticed that with different FPS I got different resolutions. I will try to prepare another reproducible example(s) and will get back with more details.

irudnyts commented 7 months ago

Here are my observations:

CAMERA_FORWARD:
- LOW_RESOLUTION: (478, 648, 3)
- HIGHT_RESOLUTION: (720, 960, 3)
CAMERA_DOWNWARD: (720, 320, 3)

Probably I should ask this in the other issue, but what exactly does the bottom camera frame consist of? If I understand correctly, the first 240 columns are camera pixels, but there rest seem to be related to infrared sensors. Is there any info on that? Once I get this info, I will send a PR.

Oh, and I was wrong, FPS does not affect the resolution, but FPS_5 does not work for me whatsoever.