search

damian / jshint

Making it easy to lint your JavaScript assets in any Rails 3.1+ and Rails 4 application.
https://rubygems.org/gems/jshint
MIT License
11 stars 21 forks source link

Remove therubyracer dependency #30

Open BrianHawley opened 9 years ago

BrianHawley commented 9 years ago

The execjs gem calls therubyracer for you if therubyracer is included in the application's Gemfile, but if it's appropriate for the application to use another supported runtime then execjs will use that. The therubyracer gem isn't supported in JRuby, for instance, nor is it supported on Windows.

You can remove the direct dependency on therubyracer, and instead recommend its use in the README file.

damian commented 9 years ago

That's a good shout - though it'll have to wait till v2 as this is potentially a change which isn't backwards compatible.

damian commented 9 years ago

In fact someones kindly provided a PR to achieve this. There are one or two other things that I want to address before releasing v2, but your suggestion will definitely make it's way in to JSHint.