Open pytkr opened 5 years ago
@pytkr do you have some minimal example to reproduce the issue. A binder would be nice, but otherwise, a link to an example ipynb showing the behaviour would be nice.
causes code cell lengthening a lot
Can you clarify or showcase somehow this behaviour (maybe a gif or a video)
Thanks!
@pytkr do you have some minimal example to reproduce the issue. A binder would be nice, but otherwise, a link to an example ipynb showing the behaviour would be nice.
causes code cell lengthening a lot
Can you clarify or showcase somehow this behaviour (maybe a gif or a video)
Thanks!
I upload a gif file to show the concave slide causing long blank lines: Gif https://github.com/pytkr/bugFiles/blob/master/rise%20test%20with%20long%20code.gif
Ipynb test file: https://github.com/pytkr/bugFiles/blob/master/test_bug_slide_concave.ipynb
Furthermore, I find the blank lines, too, when zooming in and out the slide with long code cell with word wrapping (the 3rd code in ipynb), even under none slide transition, namely, it's OK when code wrapped, but blank lines show below last line when zoomed out to make all lines roomy to contain whole line.
I'm getting 404 on both links, is the repo publicly open ?
besides, when you say zooming in and out you mean with Command+ / Command- , right ? (or Control+ / Control-);
if not please explicit how you zoom exactly
thanks !
besides, when you say zooming in and out you mean with Command+ / Command- , right ? (or Control+ / Control-);
if not please explicit how you zoom exactly thanks !
Sorry for the link, I didn't know private repo will be banned even the link at all, so I change it to public now, please access them, thanks!
And I use ctrl + mouse middle wheel up/down to zoom in and out on slide page with chrome browser.
hey
I could just today take a look at the screenclip; what you have is bad indeed !
so first off, why are you saying this has anything to do with slide switching ? as far as your clip show it, it feels like cells with a long code are showing up with extra vertical space, but I failed to see how this was related to slide transitions; even more so as your notebook has no rise metadata set.. what am I missing here ?
otherwise I did try to reproduce; I only have the dev version if rise at hand (5.6.0.dev4 specifically) and could not see this happening; I can't scroll down though, but using smaller chars to zoom out I can see the cells are behaving properly
FYI you can install the dev version with pip install --pre -U rise
EDIT 2019/11: release 5.6 is now officially published, the --pre
option is no longer required
otherwise I did try to reproduce; I only have the dev version if rise at hand (5.6.0.dev4 specifically) and could not see this happening; I can't scroll down though, but using smaller chars to zoom out I can see the cells are behaving properly
FYI you can install the dev version with
pip install --pre -U rise
Still the same, I uninstalled rise under conda then executed this installation, default / slide / fade is fine, however, Concave / Convex / Zoom causes lengthened code cell, in chrome, firefox and edge browser, windows 10 x64.
I can reproduce this bug on windows 7 x64 and another windows 10 x64, too: // 1. download miniconda3 from official site and run to install // 2. open from start menu and start Anaconda Prompt (Miniconda3) // 3. run following commands
conda install jupyter notebook
conda install rise # or pip install --pre -U rise
EDIT 2019/11: release 5.6 is now officially published, the --pre
option is no longer required
// 4. start jupyter notebook
// 5. create new .ipynb and create md cell, code cell of 30 lines of import sys
and md cell, and change all cells's slide type to slide, then click the button on toolbar, enter slide mode, and the default mode is fine
// 6. then, I directly edit the notebook metadata, by adding these and save:
,
"rise": {
"transition": "concave",
"scroll": true,
"theme": "white"
}
// refresh the page and enter into slide mode, the code cell are lengthened as well, sadly.
The info of installation is following: windows 7 x64:
(base) C:\Users\test>conda list
# packages in environment at C:\ProgramData\Miniconda3:
#
# Name Version Build Channel
asn1crypto 0.24.0 py37_0
attrs 19.1.0 py37_1
backcall 0.1.0 py37_0
bleach 3.1.0 py37_0
bzip2 1.0.8 he774522_0
ca-certificates 2019.6.16 hecc5488_0 conda-forge
certifi 2019.6.16 py37_1 conda-forge
cffi 1.12.3 py37h7a1dbc1_0
chardet 3.0.4 py37_1
colorama 0.4.1 py37_0
conda 4.7.11 py37_0 conda-forge
conda-package-handling 1.3.11 py37_0
console_shortcut 0.1.1 3
cryptography 2.7 py37h7a1dbc1_0
decorator 4.4.0 py37_1
defusedxml 0.6.0 py_0
entrypoints 0.3 py37_0
icu 58.2 ha66f8fd_1
idna 2.8 py37_0
ipykernel 5.1.1 py37h39e3cac_0
ipython 7.7.0 py37h39e3cac_0
ipython_genutils 0.2.0 py37_0
ipywidgets 7.5.1 py_0
jedi 0.13.3 py37_0
jinja2 2.10.1 py37_0
jpeg 9b hb83a4c4_2
jsonschema 3.0.1 py37_0
jupyter 1.0.0 py37_7
jupyter_client 5.3.1 py_0
jupyter_console 6.0.0 py37_0
jupyter_contrib_core 0.3.3 py_2 conda-forge
jupyter_contrib_nbextensions 0.5.1 py37_0 conda-forge
jupyter_core 4.5.0 py_0
jupyter_highlight_selected_word 0.2.0 py37_1000 conda-forge
jupyter_latex_envs 1.4.4 py37_1000 conda-forge
jupyter_nbextensions_configurator 0.4.1 py37_0 conda-forge
libarchive 3.3.3 h0643e63_5
libiconv 1.15 h1df5818_7
libpng 1.6.37 h2a8f88b_0
libsodium 1.0.16 h9d3ae62_0
libxml2 2.9.9 h464c3ec_0
libxslt 1.1.32 heafd4d3_1004 conda-forge
lxml 4.4.1 py37heafd4d3_0 conda-forge
lz4-c 1.8.1.2 h2fa13f4_0
lzo 2.10 h6df0209_2
m2w64-gcc-libgfortran 5.3.0 6
m2w64-gcc-libs 5.3.0 7
m2w64-gcc-libs-core 5.3.0 7
m2w64-gmp 6.1.0 2
m2w64-libwinpthread-git 5.0.0.4634.697f757 2
markupsafe 1.1.1 py37he774522_0
menuinst 1.4.16 py37he774522_0
mistune 0.8.4 py37he774522_0
msys2-conda-epoch 20160418 1
nbconvert 5.5.0 py_0
nbformat 4.4.0 py37_0
notebook 6.0.0 py37_0
openssl 1.1.1c hfa6e2cd_0 conda-forge
pandoc 2.2.3.2 0
pandocfilters 1.4.2 py37_1
parso 0.5.0 py_0
pickleshare 0.7.5 py37_0
pip 19.1.1 py37_0
powershell_shortcut 0.0.1 2
prometheus_client 0.7.1 py_0
prompt_toolkit 2.0.9 py37_0
pycosat 0.6.3 py37hfa6e2cd_0
pycparser 2.19 py37_0
pygments 2.4.2 py_0
pyopenssl 19.0.0 py37_0
pyqt 5.9.2 py37h6538335_2
pyrsistent 0.14.11 py37he774522_0
pysocks 1.7.0 py37_0
python 3.7.3 h8c8aaf0_1
python-dateutil 2.8.0 py37_0
python-libarchive-c 2.8 py37_11
pywin32 223 py37hfa6e2cd_1
pywinpty 0.5.5 py37_1000
pyyaml 5.1.2 py37hfa6e2cd_0 conda-forge
pyzmq 18.0.0 py37ha925a31_0
qt 5.9.7 vc14h73c81de_0
qtconsole 4.5.2 py_0
requests 2.22.0 py37_0
rise 5.4.1 py37_1000
ruamel_yaml 0.15.46 py37hfa6e2cd_0
send2trash 1.5.0 py37_0
setuptools 41.0.1 py37_0
sip 4.19.8 py37h6538335_0
six 1.12.0 py37_0
sqlite 3.29.0 he774522_0
terminado 0.8.2 py37_0
testpath 0.4.2 py37_0
tornado 6.0.3 py37he774522_0
tqdm 4.32.1 py_0
traitlets 4.3.2 py37_0
urllib3 1.24.2 py37_0
vc 14.1 h0510ff6_4
vs2015_runtime 14.15.26706 h3a45250_4
wcwidth 0.1.7 py37_0
webencodings 0.5.1 py37_1
wheel 0.33.4 py37_0
widgetsnbextension 3.5.0 py37_0
win_inet_pton 1.1.0 py37_0
wincertstore 0.2 py37_0
winpty 0.4.3 4
xz 5.2.4 h2fa13f4_4
yaml 0.1.7 hc54c509_2
zeromq 4.3.1 h33f27b4_3
zlib 1.2.11 h62dcd97_3
zstd 1.3.7 h508b16e_0
windows 10 x64:
C:\Users\test>conda list
# packages in environment at C:\Users\test\Anaconda3:
#
_ipyw_jlab_nb_ext_conf 0.1.0 py36he6757f0_0 defaults
alabaster 0.7.10 py36hcd07829_0 defaults
anaconda custom py36_0 https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
anaconda-client 1.7.2 py36_0 defaults
anaconda-navigator 1.9.7 py36_0 defaults
anaconda-project 0.8.0 py36h8b3bf89_0 defaults
asn1crypto 0.22.0 py36h8e79faa_1 defaults
astroid 1.5.3 py36h9d85297_0 defaults
astropy 2.0.2 py36h06391c4_4 defaults
babel 2.5.0 py36h35444c1_0 defaults
backports 1.0 py36h81696a8_1 defaults
backports.shutil_get_terminal_size 1.0.0 py36h79ab834_2 defaults
beautifulsoup4 4.6.0 py36hd4cc5e8_1 defaults
bitarray 0.8.1 py36h6af124b_0 defaults
bkcharts 0.2 py36h7e685f7_0 defaults
blas 1.0 mkl https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
blaze 0.11.3 py36h8a29ca5_0 defaults
bleach 2.0.0 py36h0a7e3d6_0 defaults
bokeh 0.12.10 py36h0be3b39_0 defaults
boto 2.48.0 py36h1a776d2_1 defaults
bottleneck 1.2.1 py36hd119dfa_0 defaults
bzip2 1.0.6 vc14hdec8e7a_1 [vc14] defaults
ca-certificates 2017.08.26 h94faf87_0 defaults
cachecontrol 0.12.3 py36hfe50d7b_0 defaults
certifi 2017.7.27.1 py36h043bc9e_0 defaults
cffi 1.10.0 py36hae3d1b5_1 defaults
chardet 3.0.4 py36h420ce6e_1 defaults
click 6.7 py36hec8c647_0 defaults
cloudpickle 0.4.0 py36h639d8dc_0 defaults
clyent 1.2.2 py36hb10d595_1 defaults
colorama 0.3.9 py36h029ae33_0 defaults
comtypes 1.1.2 py36heb9b3d1_0 defaults
conda 4.3.30 py36h7e176b0_0 https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
conda-build 3.0.27 py36h309a530_0 defaults
conda-env 2.6.0 0 https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
conda-verify 2.0.0 py36h065de53_0 defaults
console_shortcut 0.1.1 h6bb2dd7_3 defaults
contextlib2 0.5.5 py36he5d52c0_0 defaults
cryptography 2.0.3 py36h123decb_1 defaults
curl 7.55.1 vc14hdaba4a4_3 [vc14] defaults
cycler 0.10.0 py36h009560c_0 defaults
cython 0.26.1 py36h18049ac_0 defaults
cytoolz 0.8.2 py36h547e66e_0 defaults
dask 0.15.3 py36h396fcb9_0 defaults
dask-core 0.15.3 py36hd651449_0 defaults
datashape 0.5.4 py36h5770b85_0 defaults
decorator 4.1.2 py36he63a57b_0 defaults
distlib 0.2.5 py36h51371be_0 defaults
distributed 1.19.1 py36h8504682_0 defaults
docutils 0.14 py36h6012d8f_0 defaults
entrypoints 0.2.3 py36hfd66bb0_2 defaults
et_xmlfile 1.0.1 py36h3d2d736_0 defaults
fastcache 1.0.2 py36hffdae1b_0 defaults
filelock 2.0.12 py36hd7ddd41_0 defaults
flask 0.12.2 py36h98b5e8f_0 defaults
flask-cors 3.0.3 py36h8a3855d_0 defaults
freetype 2.8 vc14h17c9bdf_0 [vc14] defaults
get_terminal_size 1.0.0 h38e98db_0 defaults
gevent 1.2.2 py36h342a76c_0 defaults
glob2 0.5 py36h11cc1bd_1 defaults
greenlet 0.4.12 py36ha00ad21_0 defaults
h5py 2.7.0 py36hfbe0a52_1 defaults
hdf5 1.10.1 vc14hb361328_0 [vc14] defaults
heapdict 1.0.0 py36h21fa5f4_0 defaults
html5lib 0.999999999 py36ha09b1f3_0 defaults
icc_rt 2017.0.4 h97af966_0 defaults
icu 58.2 vc14hc45fdbb_0 [vc14] defaults
idna 2.6 py36h148d497_1 defaults
imageio 2.2.0 py36had6c2d2_0 defaults
imagesize 0.7.1 py36he29f638_0 defaults
intel-openmp 2018.0.0 hcd89f80_7 defaults
ipykernel 4.6.1 py36hbb77b34_0 defaults
ipython 6.1.0 py36h236ecc8_1 defaults
ipython_genutils 0.2.0 py36h3c5d0ee_0 defaults
ipywidgets 7.0.0 py36h2e74ada_0 defaults
isort 4.2.15 py36h6198cc5_0 defaults
itsdangerous 0.24 py36hb6c5a24_1 defaults
jdcal 1.3 py36h64a5255_0 defaults
jedi 0.10.2 py36hed927a0_0 defaults
jinja2 2.9.6 py36h10aa3a0_1 defaults
jpeg 9b vc14h4d7706e_1 [vc14] defaults
jsonschema 2.6.0 py36h7636477_0 defaults
jupyter 1.0.0 py36_3 https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
jupyter_client 5.3.1 py_0 defaults
jupyter_console 5.2.0 py36h6d89b47_1 defaults
jupyter_core 4.5.0 py_0 defaults
jupyterlab 0.27.0 py36h34cc53b_2 defaults
jupyterlab_launcher 0.4.0 py36h22c3ccf_0 defaults
lazy-object-proxy 1.3.1 py36hd1c21d2_0 defaults
libiconv 1.15 vc14h29686d3_5 [vc14] defaults
libpng 1.6.32 vc14h5163883_3 [vc14] defaults
libssh2 1.8.0 vc14hcf584a9_2 [vc14] defaults
libtiff 4.0.8 vc14h04e2a1e_10 [vc14] defaults
libxml2 2.9.4 vc14h8fd0f11_5 [vc14] defaults
libxslt 1.1.29 vc14hf85b8d4_5 [vc14] defaults
llvmlite 0.20.0 py36_0 defaults
locket 0.2.0 py36hfed976d_1 defaults
lockfile 0.12.2 py36h0468280_0 defaults
lxml 4.1.0 py36h0dcd83c_0 defaults
lzo 2.10 vc14h0a64fa6_1 [vc14] defaults
m2w64-gcc-libgfortran 5.3.0 6 defaults
m2w64-gcc-libs 5.3.0 7 defaults
m2w64-gcc-libs-core 5.3.0 7 defaults
m2w64-gmp 6.1.0 2 defaults
m2w64-libwinpthread-git 5.0.0.4634.697f757 2 defaults
markupsafe 1.0 py36h0e26971_1 defaults
matplotlib 2.1.0 py36h11b4b9c_0 defaults
mccabe 0.6.1 py36hb41005a_1 defaults
menuinst 1.4.10 py36h42196fb_0 defaults
mistune 0.7.4 py36h4874169_0 defaults
mkl 2018.0.0 h36b65af_4 defaults
mkl-service 1.1.2 py36h57e144c_4 defaults
mpmath 0.19 py36he326802_2 defaults
msgpack-python 0.4.8 py36h58b1e9d_0 defaults
msys2-conda-epoch 20160418 1 defaults
multipledispatch 0.4.9 py36he44c36e_0 defaults
navigator-updater 0.1.0 py36h8a7b86b_0 defaults
nbconvert 5.3.1 py36h8dc0fde_0 defaults
nbformat 4.4.0 py36h3a5bc1b_0 defaults
networkx 2.0 py36hff991e3_0 defaults
nltk 3.2.4 py36hd0e0a39_0 defaults
nose 1.3.7 py36h1c3779e_2 defaults
notebook 6.0.0 py36_0 defaults
numba 0.35.0 np113py36_10 defaults
numexpr 2.6.2 py36h7ca04dc_1 defaults
numpy 1.13.3 py36ha320f96_0 defaults
numpydoc 0.7.0 py36ha25429e_0 defaults
odo 0.5.1 py36h7560279_0 defaults
olefile 0.44 py36h0a7bdd2_0 defaults
openpyxl 2.4.8 py36hf3b77f6_1 defaults
openssl 1.0.2l vc14hcac20b0_2 [vc14] defaults
packaging 16.8 py36ha0986f6_1 defaults
pandas 0.20.3 py36hce827b7_2 defaults
pandoc 1.19.2.1 hb2460c7_1 defaults
pandocfilters 1.4.2 py36h3ef6317_1 defaults
partd 0.3.8 py36hc8e763b_0 defaults
path.py 10.3.1 py36h3dd8b46_0 defaults
pathlib2 2.3.0 py36h7bfb78b_0 defaults
patsy 0.4.1 py36h42cefec_0 defaults
pep8 1.7.0 py36h0f3d67a_0 defaults
pickleshare 0.7.4 py36h9de030f_0 defaults
pillow 4.2.1 py36hdb25ab2_0 defaults
pip 19.2.2 <pip>
pip 9.0.1 py36hadba87b_3 defaults
pkginfo 1.4.1 py36hb0f9cfa_1 defaults
ply 3.10 py36h1211beb_0 defaults
progress 1.3 py36hbeca8d3_0 defaults
prometheus_client 0.7.1 py_0 defaults
prompt_toolkit 1.0.15 py36h60b8f86_0 defaults
psutil 5.4.0 py36h4e662fb_0 defaults
py 1.4.34 py36ha4aca3a_1 defaults
pycodestyle 2.3.1 py36h7cc55cd_0 defaults
pycosat 0.6.2 py36hf17546d_1 defaults
pycparser 2.18 py36hd053e01_1 defaults
pycrypto 2.6.1 py36he68e6e2_1 defaults
pycurl 7.43.0 py36h086bf4c_3 defaults
pyflakes 1.6.0 py36h0b975d6_0 defaults
pygments 2.2.0 py36hb010967_0 defaults
pylint 1.7.4 py36ha4e6ded_0 defaults
PyMuPDF 1.14.2 <pip>
pyodbc 4.0.17 py36h0006bc2_0 defaults
pyopenssl 17.2.0 py36h15ca2fc_0 defaults
pyparsing 2.2.0 py36h785a196_1 defaults
pyqt 5.6.0 py36hb5ed885_5 defaults
pysocks 1.6.7 py36h698d350_1 defaults
pytables 3.4.2 py36h71138e3_2 defaults
pytest 3.2.1 py36h753b05e_1 defaults
python 3.6.3 h9e2ca53_1 defaults
python-dateutil 2.6.1 py36h509ddcb_1 defaults
pytz 2017.2 py36h05d413f_1 defaults
pywavelets 0.5.2 py36hc649158_0 defaults
pywin32 221 py36h9c10281_0 defaults
pywinpty 0.5.5 py36_1000 defaults
pyyaml 3.12 py36h1d1928f_1 defaults
pyzmq 17.0.0 py36hfa6e2cd_0 defaults
qt 5.6.2 vc14h6f8c307_12 [vc14] defaults
qtawesome 0.4.4 py36h5aa48f6_0 defaults
qtconsole 4.3.1 py36h99a29a9_0 defaults
qtpy 1.8.0 py_0 defaults
requests 2.18.4 py36h4371aae_1 defaults
rise 5.6.0.dev4 <pip>
rope 0.10.5 py36hcaf5641_0 defaults
ruamel_yaml 0.11.14 py36h9b16331_2 defaults
scikit-image 0.13.0 py36h6dffa3f_1 defaults
scikit-learn 0.19.1 py36h53aea1b_0 defaults
scipy 0.19.1 py36h7565378_3 defaults
seaborn 0.8.0 py36h62cb67c_0 defaults
send2trash 1.5.0 py36_0 defaults
setuptools 36.5.0 py36h65f9e6e_0 defaults
simplegeneric 0.8.1 py36heab741f_0 defaults
singledispatch 3.4.0.3 py36h17d0c80_0 defaults
sip 4.18.1 py36h9c25514_2 defaults
six 1.11.0 py36h4db2310_1 defaults
snowballstemmer 1.2.1 py36h763602f_0 defaults
sortedcollections 0.5.3 py36hbefa0ab_0 defaults
sortedcontainers 1.5.7 py36ha90ac20_0 defaults
sphinx 1.6.3 py36h9bb690b_0 defaults
sphinxcontrib 1.0 py36hbbac3d2_1 defaults
sphinxcontrib-websupport 1.0.1 py36hb5e5916_1 defaults
spyder 3.2.4 py36h8845eaa_0 defaults
sqlalchemy 1.1.13 py36h5948d12_0 defaults
sqlite 3.20.1 vc14h7ce8c62_1 [vc14] defaults
statsmodels 0.8.0 py36h6189b4c_0 defaults
sympy 1.1.1 py36h96708e0_0 defaults
tblib 1.3.2 py36h30f5020_0 defaults
terminado 0.8.2 py36_0 defaults
testpath 0.3.1 py36h2698cfe_0 defaults
tk 8.6.7 vc14hb68737d_1 [vc14] defaults
toolz 0.8.2 py36he152a52_0 defaults
tornado 5.1.1 py36hfa6e2cd_0 defaults
tornado 6.0.3 <pip>
traitlets 4.3.2 py36h096827d_0 defaults
typing 3.6.2 py36hb035bda_0 defaults
unicodecsv 0.14.1 py36h6450c06_0 defaults
urllib3 1.22 py36h276f60a_0 defaults
vc 14 h2379b0c_2 defaults
vs2015_runtime 14.0.25123 hd4c4e62_2 defaults
wcwidth 0.1.7 py36h3d5aa90_0 defaults
webencodings 0.5.1 py36h67c50ae_1 defaults
werkzeug 0.12.2 py36h866a736_0 defaults
wheel 0.29.0 py36h6ce6cde_1 defaults
widgetsnbextension 3.0.2 py36h364476f_1 defaults
win_inet_pton 1.0.1 py36he67d7fd_1 defaults
win_unicode_console 0.5 py36hcdbd4b5_0 defaults
wincertstore 0.2 py36h7fe50ca_0 defaults
winpty 0.4.3 4 defaults
wrapt 1.10.11 py36he5f5981_0 defaults
xlrd 1.1.0 py36h1cb58dc_1 defaults
xlsxwriter 1.0.2 py36hf723b7d_0 defaults
xlwings 0.11.4 py36hd3cf94d_0 defaults
xlwt 1.3.0 py36h1a4751e_0 defaults
yaml 0.1.7 vc14hb31d195_1 [vc14] defaults
zict 0.1.3 py36h2d8e73e_0 defaults
zlib 1.2.11 vc14h1cdd9ab_1 [vc14] defaults
otherwise I did try to reproduce; I only have the dev version if rise at hand (5.6.0.dev4 specifically) and could not see this happening; I can't scroll down though, but using smaller chars to zoom out I can see the cells are behaving properly
FYI you can install the dev version with
pip install --pre -U rise
SOLVED!
Just comment following line in file %USERPROFILE%\Miniconda3\share\jupyter\nbextensions\rise\main.js
:
auto_select: 'code',
and everything works, now, so happy to find this! @damianavila Thanks so much for such a powerful tool!
@pytkr nice to see you solved it.
@parmentelat do you have any remote idea why auto_select: 'code'
could trigger a behaviour like this?
None whatsoever
Should we make a note in the docs about this? Not sure what resolution step we should take here. I do not think we have resources (time) to further investigate this one. So maybe a note in the docs is enough for now...
Unless the docs will be updated, I recommend closing this ticket.
I still think a note in the docs is necessary, let's keep it open for now.
However, default/slide/fade doesn't have such a symptom, can this be fixed? thanks.