search

damianavila / RISE

RISE: "Live" Reveal.js Jupyter/IPython Slideshow Extension
Other
3.67k stars 416 forks source link

pass chalkboard settings along to reveal #505

Closed rinnert closed 5 years ago

rinnert commented 5 years ago

It seems currently not possible to alter the chalkboard settings through nbconfig/rise.json.

This a bit of a hindrance I discovered when trying to find a way to set chalkboard.readOnly to false.

The fix is quite simple, I will file a PR soon. I mostly created this issue to have something to refer to.

parmentelat commented 5 years ago

Hi

Sounds great ! As a friendly note I’d suggest that you build your PR on top of the maint-5.6 branch, or maint-5.5 if you’re conservative, as the other ones are not exactly usable right now

The 5.6 dev release is currently available with

pip install —pre rise
rinnert commented 5 years ago

Just submitted a PR for maint-5.6. The fix is so simple that I doubt it will conflict with any recent branch. I tested it with the masters of reveal.js and reveal.js-plugins/chalkboard -- seems all fine.

parmentelat commented 5 years ago

pr #506 is now merged, this is part of release 5.6.dev5 that just went out thanks