search

damianavila / RISE

RISE: "Live" Reveal.js Jupyter/IPython Slideshow Extension
Other
3.67k stars 414 forks source link

buttons get toggled off by default #568

Closed parmentelat closed 3 years ago

parmentelat commented 3 years ago

the implementation of #561 was rough; I made the mistake to think that defining a default in the yaml file would apply in the code, while defaults in yaml just act as documentation artefacts

as a result people who do not configure the show_buttons_on_startup flag end up with the buttons being toggled, which was not the intention

damianavila commented 3 years ago

Thanks for the fix @parmentelat!

damianavila commented 3 years ago

This needs to be released with a 5.7.1, right?