search

damianavila / RISE

RISE: "Live" Reveal.js Jupyter/IPython Slideshow Extension
Other
3.67k stars 414 forks source link

Update list of reveal.js config options #590

Open moble opened 3 years ago

moble commented 3 years ago

These lines suggest that more options are actually passed through. I took the descriptions from the reveal documentation. (Note that the website is currently down, so I just looked through the src.)

damianavila commented 3 years ago

@moble, thanks for the PR but even when some other options are passthrough, modifying some of them could be problematic (https://github.com/damianavila/RISE/blob/master/classic/rise/static/main.js#L110), this is why we do not advertise them. @parmentelat, maybe we need to prevent passing through some of these options... thoughts?

parmentelat commented 3 years ago

hiya everythone

well, given that, as the Python motto has it, we're all consenting adults here, I'd rather leaver this open, but indeed a few words of warning about the possible negative effects of tweaking them could be quite helpful this being said I would have a hard time trying to phrase this in any specific way...

damianavila commented 3 years ago

but indeed a few words of warning about the possible negative effects of tweaking them could be quite helpful

I would be OK with that!

this being said I would have a hard time trying to phrase this in any specific way...

Me too :wink: maybe @moble has some words for us!

moble commented 3 years ago

Me too 😉 maybe @moble has some words for us!

I'm afraid I'm more lost than ever, now. I would appreciate some direction on which options will/should work.

damianavila commented 3 years ago

I'm afraid I'm more lost than ever, now. I would appreciate some direction on which options will/should work.

I guess we are essentially asking you to add to your PR some note that warns the user that things could be wrong if they tweak those additional parameters (the ones you added).