damianh / LibLog

LibLog is a single file for you to either copy/paste or install via nuget, into your library/framework/application to provide a logging abstraction.
MIT License
929 stars 153 forks source link

.NET Full Framework 4.8 support #254

Closed chiefengineer closed 5 years ago

chiefengineer commented 5 years ago

Error:" Could not install package 'LibLog 5.0.6'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.8', but the package does not contain any assembly references or content files that are compatible with that framework.

For more information, contact the package author. "

damianh commented 5 years ago

What csproj format are you using?

chiefengineer commented 5 years ago

I dislike sounding ignorant, but...there is more than one? How can I find out?

"Bang the Button - It Just Works!"

On Thu, Aug 15, 2019 at 9:15 AM Damian Hickey notifications@github.com wrote:

What csproj format are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/damianh/LibLog/issues/254?email_source=notifications&email_token=AA6A44N66ZEIY7B3MYTZAL3QEV6IXA5CNFSM4IKPNSJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MIFRY#issuecomment-521700039, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6A44OQVOUXPOP62QETIRLQEV6IXANCNFSM4IKPNSJQ .

damianh commented 5 years ago

https://natemcmaster.com/blog/2017/03/09/vs2015-to-vs2017-upgrade/ http://www.albertocorrales.com/2018/12/why-you-should-migrate-your-old-csproj.html https://www.hanselman.com/blog/UpgradingAnExistingNETProjectFilesToTheLeanNewCSPROJFormatFromNETCore.aspx

LibLog >= 5.0.0 only supports the new "SDK" format. https://github.com/damianh/LibLog#availability-for-old-csproj-format https://github.com/damianh/LibLog/issues/237 https://github.com/damianh/LibLog/issues/220 https://github.com/damianh/LibLog/issues/202

chiefengineer commented 5 years ago

Thanks! Learn something new every day. Don't pay much attention to the "upgrade" path when it comes to framework versions, when a new version of the .NET Framework comes out, I generate new .csproj files for just those reasons and move the library code over, don't want to have to worry about cleaning up old messes and removing cruft. This should be the "new" format, the .csproj files were created specifically for this project using VS2019 Enterprise after the install of .NET Full Framework 4.8. No carryover from an older format, not an "upgrade", not a "refactoring". However, I have not yet switched to the "PackageReference" mode of package management simply because of the stated incompatibilities with some applications (see: https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files about half way down, specifically the following quote: "ASP.NET apps targeting the full .NET Framework include only limited support https://github.com/NuGet/Home/issues/5877 for PackageReference. C++ and JavaScript project types are unsupported."). When (if) that goes away, I'll make the switch. If I need to I can supply a solution that exhibits the problem. One other thing - the attempted install was not using "dotnet" but using the integrated functionality as supplied by VS2019 (went to the NuGet tab and attempted to install from there).

On Tue, Aug 20, 2019 at 2:20 AM Damian Hickey notifications@github.com wrote:

https://natemcmaster.com/blog/2017/03/09/vs2015-to-vs2017-upgrade/

http://www.albertocorrales.com/2018/12/why-you-should-migrate-your-old-csproj.html

https://www.hanselman.com/blog/UpgradingAnExistingNETProjectFilesToTheLeanNewCSPROJFormatFromNETCore.aspx

LibLog >= 5.0.0 only supports the new "SDK" format. https://github.com/damianh/LibLog#availability-for-old-csproj-format

237 https://github.com/damianh/LibLog/issues/237

220 https://github.com/damianh/LibLog/issues/220

202 https://github.com/damianh/LibLog/issues/202

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/damianh/LibLog/issues/254?email_source=notifications&email_token=AA6A44K2INQC633NFAKFIDLQFOZPRA5CNFSM4IKPNSJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4VUULI#issuecomment-522930733, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6A44OUVXXRKF2G2AIYLN3QFOZPRANCNFSM4IKPNSJQ .

damianh commented 5 years ago

Yeah the transition wasn't the smoothest and understand your approach. I couldn't support the new project format for quite a while after it was initially released (given the nature of this source code package).

It's not possible to support both formats in the one package. If you remain on the old format, for whatever reasons, the 4.x line still supports it (until it stops working - am not officially maintaining that version line).

the attempted install was not using "dotnet" but using the integrated functionality as supplied by VS2019

This is effectively the same for new sdk project formats.

Closing as there isn't anything specifically to be done.