damianh / LibLog

LibLog is a single file for you to either copy/paste or install via nuget, into your library/framework/application to provide a logging abstraction.
MIT License
929 stars 153 forks source link

LibLogException not being excluded from code coverage #267

Closed TrymBeast closed 4 years ago

TrymBeast commented 5 years ago

Hi!

So, I'm using LibLog 5.0.6 and when I set the LIBLOG_EXCLUDE_CODE_COVERAGE conditional compile symbol the LibLogException still appears in the code coverage report.

Also, why do we need to use this conditional compilation symbol? I don't see any reason for this not be the default. Does the clients of LibLog want to test LibLog and have the code coverage? My suggestion would be to inverse the logic and include the attribute by default, and a symbol could control when not to include it, because i'm sure you want to have code coverage for your own tests.

And thanks for this library!