damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
376 stars 13 forks source link

[Bug] Collapse left sidebar button too high #104

Closed bb closed 1 year ago

bb commented 1 year ago

Describe the bug

The Toolbar button "Collapse left sidebar" is too high on macOS when Appearance→Advanced→Window Frame Style "Hidden (default)" is selected. Also, it should be on the left, but it's on the right. See screenshot.

It's fine when using another window frame style and also fine in full screen.

To Reproduce

  1. Open Obsidian on macOS Ventura
  2. Ensure you're not in full screen mode
  3. In Settings → Appearance → Advanced → Window frame style, ensure "Hidden (default)" is selected
  4. Add icons like Folders, Favorites, Search, Recent (or similar) to the toolbar)
  5. Compare height of the toolbar items, for me "Collapse left sidebar" is too high.

Expected behavior

All toolbar items should have the same height

Screenshots

Setup Information

damiankorcz commented 1 year ago

Hi @bb, This should now be addressed in Prism 3.1.1. Also, the button by default is on the right when the sidebar is expanded but I've fixed the alignment to match the default theme now.

I have a way to test on macOS now so if you encounter any other issues let me know! Thanks for reporting.

bb commented 1 year ago

The height of the button is fixed for me, thank you!