damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
394 stars 13 forks source link

[FR] Quote new line separation in editing vs reading modes #118

Closed mbentley closed 1 year ago

mbentley commented 1 year ago

Is your feature request related to a problem? Please describe. I am not sure if this is a design decision or not; when in reading mode vs editing mode, multi-line quotes are separated by a border in editing mode but I would expect them to display like they do in reading mode with no separation of the quote.

Raw markdown:

> This is a quote.  This could be a much longer sentence if I really wanted it to be so here is some more info that I could possible put in this.  I hope this is long enough because I am tired of typing.
> New line of a quote

> New quote, separated by blank line

Editing mode: screenshot 2023-01-19 at 10 41 20 AM

Reading mode: screenshot 2023-01-19 at 10 41 24 AM

Describe the solution you'd like Editing mode would look like reading mode.

Describe alternatives you've considered I was looking at trying to change this using a CSS snippet but I was having issues trying to do so.

Additional context Screen shots above.

damiankorcz commented 1 year ago

Hi @mbentley, I'm aware of this and will likely look for an alternative design that I can keep consistent across modes. At the moment there is no way for me to target the start and end of a blockquote individually in editing modes. So the start, in-between and the end all have to share the same code. which results in the unwanted top and bottom borders when using several lines. Will likely resort to possibly adding a subtle background colour and only doing the side borders. Will have to think about this one 😅


P.S. I've had a similar issue with Inline code but I've managed to get some help with resolving that and it will be in the next update. In that case there was a way to differentiate the parts that make it up so the bordered design can stay.

How that looks currently: image

Solution 1: image

Solution 2: image

damiankorcz commented 1 year ago

Hi @mbentley, This is now addressed in Prism 3.2.1. I've basically reverted the design to what the default theme uses with an addition of a different background colour to help differentiate it from other content. I've had too many difficulties doing anything else while making it consistent across all editor modes.