damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
369 stars 13 forks source link

Local graph becomes black after changing mode (dark/light) #133

Closed kudrmax closed 2 months ago

kudrmax commented 1 year ago

Describe the bug

After changing theme mode from dark to light or from light to dark colors of any part of local graph becomes black. If go to Style Setting tab -> Prism Theme -> Appearance -> Graph Color Customisation -> Graph lines color and press Restore default button, then bug disappears.

To Reproduce

  1. Open local graph
  2. Change theme mode (light/dark)

Screenshots

Before:

image

After:

image image

Setup Information

Additional context

I tested this bug in empty new vault without any other plugin accept Style Setting, and bug still exists.

garbosz commented 4 months ago

+1 on this

Setup Information

kazerniel commented 4 months ago

Mine has the right colours at launch, then after a few seconds it switches to all black regardless of dark/light mode. (I usually have mode set to 'adapt to system', but it behaves the same at any mode setting.)

FeralFlora commented 3 months ago

I keep wondering about the colors of the local graph (or lack thereof), and then I remember this issue. Would love to see this fixed, as it's one of the few drawbacks of the Prism theme.

damiankorcz commented 3 months ago

I think I've finally identified the issue. Still have a few things to resolve but there will at least be a partial fix for this that prevents the colours from disappearing in the next update 🥳

damiankorcz commented 2 months ago

Hi all, The partial fix should now be available in Prism 3.5.3. The update requires Obsidian app version 1.6.0 or above.

The current problem is that if you switch between Light / Dark theme the graph colours will use the shades from Swan / Raven colour schemes since the partial fix was to make those the default colours which other colour schemes replace. Strangely if you change any setting in Style Settings it triggers a reload of some kind that will load the correct colour scheme colours. Not sure how I will resolve this yet so for now it's something we'll have to deal with. I can only assume these issues are due either how Obsidian loads graph colours, how Style Settings injects the CSS or a combination of both.

Since the issue outlined has been addressed I'll close this issue but will continue to look for a solution to the above.