search

damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
369 stars 13 forks source link

Two Tone Color Scheme #152

Closed ShahriarKh closed 6 months ago

ShahriarKh commented 8 months ago

Currently, we have: ✅ Minimal ✅ Border ✅ Two Tone & Border

Another one can be added: ✳ Two Tone

P.S. I tried looking at the source code to see if I can create it myself, but couldn't find out how color schemes are handled.

damiankorcz commented 6 months ago

Hi @ShahriarKh, I've considered adding it as a scheme when I added this option but in my opinion it looks quite bad. Looks unfinished in a way. Hence why it is missing. I don't intend on adding it. Also the current implementation of the other options is very minimal and elegant. I don't think this would be worth adding more lines of code just to make it better.

https://github.com/damiankorcz/Prism-Theme/blob/39ed0d79438acdbfbb8c1b6511ddeb5e6066c186/src/scss/Variables/coreVariables.scss#L492-L501

image

image

ShahriarKh commented 6 months ago

I see. I thought it will look good, but your screenshots clearly show that some parts require borders to look good. Thank you for your explanation 🫱🏼‍🫲🏽