damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
369 stars 13 forks source link

Custom dark mode color setting breaks completely - I believe this is due to Obsidian removing Translucency in the latest beta. #158

Closed DudeThatsErin closed 4 months ago

DudeThatsErin commented 5 months ago

Describe the bug When I enabled the theme and have custom selected, I can't use the theme anymore. I have closed and reopened Obsidian but the theme is unusuable.

To Reproduce

  1. Enable theme
  2. Enable Style Settings
  3. Change Theme Option for the color (I think) to Custom

Expected behavior A custom theme be applied and allow me to change it.

Screenshots image image

Setup Information

It is not my plugins or settings because it happens in the sandbox vault as well with only Prism and Style Settings installed.

Additional context Latest release, Obsidian disabled translucency for Windows due to an upstream Electron bug they are fixing and it seems like this "custom" color is trying to add that and breaking due to that not being an option anymore.

damiankorcz commented 5 months ago

Hi @DudeThatsErin, The custom option in Color Schemes is intended to be used when you create your own Color Scheme. More info on that here: https://github.com/damiankorcz/Prism-Theme/wiki/Creating-a-Custom-Colour-Scheme-CSS-Snippet

As to recovering your Vault back to normal:

  1. Turn off Obsidian.
  2. Navigate to your vault's main folder.
  3. In there go to: .obsidian/plugins/obsidian-style-settings/data.json
  4. Open the file and edit the following lines to match:
    "obsidian-prism-theme@@color-schemes-lt": "pt-color-scheme-swan-lt",
    "obsidian-prism-theme@@color-schemes-dt": "pt-color-scheme-raven-dt",
  5. Save the file and reopen your vault.

I'll see if I can make this less confusing in a future update.

damiankorcz commented 4 months ago

Hi @DudeThatsErin, This issue should now be resolved in Prism 3.5.0. I've made the custom option utilise the colours of the Swan and Raven Colour scheme for Light and Dark respectively; preventing the issue you had. This way you can still overwrite the colours but you don't end up with an unusable vault 😅