damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
369 stars 13 forks source link

Custom color scheme colors optioni breaking the theme #161

Closed Groomingstream9 closed 5 months ago

Groomingstream9 commented 5 months ago

Describe the bug Prism theme doesn't work and breaks when chosen custom color in color scheme parameter (i.e. raven)

Steps to reproduce the behavior:

  1. Go to Settings > Community plugins > Style settings > Prism Theme> Appearance > Accent, Color Schemes and Style > Dark theme > Color scheme
  2. Configure any colors in 'Custom Color Accent Tuning' Down below
  3. Choose "Custom" in Color Scheme parameter
  4. See error

Expected behavior Colors should change to chosen custom ones

Screenshots image

Setup Information

damiankorcz commented 5 months ago

Hi @Groomingstream9, I think you misunderstood things a little by mixing 2 separate features.

The Custom Color Accent Tuning option is to set a custom Accent Color. You select the colors you want there and then set the Accent Color Preset to Custom to use it.

The Custom option in Color Scheme is intended for fully custom color schemes which the process of creating is described in the following wiki guide: https://github.com/damiankorcz/Prism-Theme/wiki/Creating-a-Custom-Colour-Scheme-CSS-Snippet

As for Obsidian looking broken after setting the Custom option in Color Scheme, I have already been made aware of this in issue #158 and have addressed it ready for the next Prism release.

Sorry for the inconvenience.