search

damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
369 stars 13 forks source link

Add support for the Note toolbar plugin #169

Closed FeralFlora closed 2 months ago

FeralFlora commented 3 months ago

Is your feature request related to a problem? Please describe. I was looking to try out the Note toolbar plugin, but got stuck trying to make the toolbars look nicer, because it was looking really strange (see image). Then, after switching to the default theme, I realized that it was a theme issue.

Here's what a note toolbar looks like when using Prism:

image

Here's the settings I've applied when configuring the note toolbar (refer to the plugin docs to see what each option ought to do: https://github.com/chrisgurney/obsidian-note-toolbar/wiki/Styling-toolbars#how-styles-are-applied).

image

As you can see, the Note toolbar shouldn't have a border, according to my settings, and each item should be styled as a button.

Describe the solution you'd like I would like for the note toolbar to be styled correctly while using the Prism theme. Correctly meaning that the style settings set in the Note toolbar's settings actually apply. As they do here with the default theme:

image

Describe alternatives you've considered Making this request in the Note toolbar repo instead. Sorry if this request is misplaced. However, as you can see below, Prism seems to be the theme that deviates the furthest from the expected styling.

Additional context Note toolbar styling with some other themes:

Polka

image

(note toolbar border is the same as the one applied to callouts)

Aura

image

Minimal

image

AnuPpuccin

image

Border

image

MagicUser

image

damiankorcz commented 3 months ago

Hi @FeralFlora, This should be resolved in an upcoming update. I'll close this issue and let you know when it's out. Not entirely sure why the plugin dev decided to use Callout styling CSS classes for this toolbar, it's what caused the border since my changes to callouts were applying to it. Had to specifically exclude them from this plugin.

FeralFlora commented 3 months ago

This should be resolved in an upcoming update.

Nice, thank you!

Not entirely sure why the plugin dev decided to use Callout styling CSS classes for this toolbar

Yeah, I don't know either. Perhaps it has something to do with the plugins other ability to render actual callouts as toolbars, and consistency in this regard? https://github.com/chrisgurney/obsidian-note-toolbar/wiki/Note-Toolbar-Callouts

damiankorcz commented 2 months ago

Hi @FeralFlora, This should now be addressed in Prism 3.5.3. Note that the release requires Obsidian app version 1.6.0 or above.

chrisgurney commented 2 months ago

@damiankorcz Thanks so much for accommodating my plugin in your theme.

Per @FeralFlora I used callout CSS for the toolbar so that the Note Toolbar callouts capability works. (The plugin originally started as just a CSS snippet.)