damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
394 stars 13 forks source link

other appearance customizations are not displayed(except Prism-Theme) in Style-Setting Plugin since update #36

Closed AiurArtanis closed 2 years ago

AiurArtanis commented 2 years ago

@damiankorcz hello again

Problem

one day i notice i couldn't customize ITS-Checkboxes snippets(#20) in Style-Setting Plugin. then i open another vault with an older version of Prism-Theme and find it works normally. image v1.3.0 image v1.5.2 it seems all appearance customizations disappear except Prism-Theme

Environment

os: win 10 ob ver: 0.13.19 prism ver: v1.5.1

Last

hope for your reply asap 😊

AiurArtanis commented 2 years ago

and i try to update the Style-Setting Plugin to the latest version and it still remains the bug

damiankorcz commented 2 years ago

Hi @AiurArtanis, I don't seem to have this issue. I'm on Obsidian v0.13.24, Prism v1.5.2 and Style Settings v0.4.9. Since you are on an older version of Obsidian try updating to the latest public build. Should be v0.13.23. See if that helps at all. Not sure what might be causing this.

image

AiurArtanis commented 2 years ago

emmm i try to update ob to ver23 then i create a new vault with only Prism-Theme, css snippet and Style-Setting, and the bug still stays: image


btw, where is this ver24 ob 🤣 the release from official page remains ver23: image

damiankorcz commented 2 years ago

It seems that we are using different snippets for the ITS Checkboxes. This is where the latest one is: https://github.com/SlRvb/Obsidian--ITS-Theme/blob/main/S%20-%20Checkboxes.css

Also version Obsidian v0.13.24 is the current insider version. I'll test more on this tomorrow.

AiurArtanis commented 2 years ago

It seems that we are using different snippets for the ITS Checkboxes. This is where the latest one is: https://github.com/SlRvb/Obsidian--ITS-Theme/blob/main/S%20-%20Checkboxes.css

i think it is nothing with this CSS snippet because i find the same case in plugin Buttons image prism:v1.3.0

image prism:v1.5.2

damiankorcz commented 2 years ago

Hi @AiurArtanis, I've tried again on a new vault with a fresh copy of Prism v1.5.2, Style Settings v0.4.9, Buttons v0.4.16 and the latest version of the ITS Checkboxes snippet. The Buttons Style Settings didn't show up for me initially so I made sure to comment out elements of the theme and slowly rebuild it by re-adding each .scss back to it. Although it's showing correctly now I see no changes in git (?) Really don't understand what is going on. I've pushed the rebuilt version of the theme to the main branch so you should be able to update and see if that does anything. Note I haven't changed the theme version number so don't worry about that.

AiurArtanis commented 2 years ago

I've pushed the rebuilt version of the theme to the main branch so you should be able to update and see if that does anything. Note I haven't changed the theme version number so don't worry about that.

i checked the commit history and didn't find the fix scss😂. or you try to fix it in v1.6.0 altogether?

AiurArtanis commented 2 years ago

it's fixed on the latest OB though i'm not sure if this update indeed works or other reason