search

damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
394 stars 13 forks source link

Highlighted text are separated into blocks in live preview when the text contains a link #57

Closed yigitozgumus closed 1 year ago

yigitozgumus commented 2 years ago

In live-preview mode

image

In preview mode

image

damiankorcz commented 2 years ago

Hi @yigitozgumus, Just an update on this issue, I've been trying to tackle it with just CSS but with the way things are structured in Obsidian across different editor views, whether the line is selected/active, etc. there is now clean way to tackle this. It has brought to my attention that similar issues also occur with Inline Code and with Quotes. I've had a semi working solution with just CSS but it's quite fragile and doesn't fully solve the issue so I've withheld from including it in the newest update (v2.2.0).

I'll try and make a Feature Request on the Obsidian forum for a potential solution; see if I can get it resolved that way. This seemingly small issue has been quite the rabbit hole 😅. I'll keep you updated on the progress once I make a Forum thread on this.

damiankorcz commented 1 year ago

Hi @yigitozgumus, I've been trying to tackle this issue for a long time and have decided to drop the styling used on == highlights because there isn't an easy fix for it (so I've been told by the devs). The highlights now look how they would in the Default theme (simple background colour) and inherit the Accent colour you chose for the UI. I might add a Style Settings option to change it to a preset colour or even a custom one in the future.

Also, I'm aware of the issue of using external links in a == highlight, where the icon doesn't have the highlight background colour. I've notified the devs about it so it will likely be addressed.

Sorry for taking so long to get back to you on this on!