damiankorcz / Prism-Theme

A Comprehensive, Highly-Customisable and Elegant Light/Dark Theme for Obsidian.md
https://www.buymeacoffee.com/DamianKorcz
MIT License
376 stars 13 forks source link

[Bug]Selected text highlight not visible in dark mode #99

Closed ZephiraZ closed 1 year ago

ZephiraZ commented 1 year ago

[Please fill out the following sections as best you can to help diagnose the issue. Remove all [ ] bracket enclosed description/example elements including this one before submitting the bug.]

Describe the bug When using Prism in dark mode, the highlight on selected text is not visible. This issue does not occur in light mode, with the default theme, or with other themes. No CSS snippets have been loaded, and the issue also occurs with all plugins disabled.

To Reproduce

  1. Use any dark mode Prism preset.
  2. Open a note containing text.
  3. Select the text with Ctrl+A, Shift+Arrow Keys, or clicking and dragging around the text.
  4. The selected text highlight is not visible.

Expected behavior It is expected that a highlight will be visible around all selected text.

Screenshots https://user-images.githubusercontent.com/102687150/202828297-54e4efce-5bee-4312-ab2f-7bdd3093cfe6.mp4

Setup Information

Additional context This issue was first observed after updating to 3.0.3. I have never used other CSS snippets, or other themes.

https://user-images.githubusercontent.com/102687150/202828297-54e4efce-5bee-4312-ab2f-7bdd3093cfe6.mp4

damiankorcz commented 1 year ago

Hi @ZephiraZ, Thanks for reporting it here. I can replicate the issue. Looks like I've messed up with assigning the custom accent colour to the text highlight. Will look to fix it this weekend.

damiankorcz commented 1 year ago

Hi @ZephiraZ, This should now be resolved in 3.0.4. Also, refer to the Important message in the changelog since I think it will apply in your case. https://github.com/damiankorcz/Prism-Theme/releases/tag/3.0.4