As per https://github.com/damianociarla/node-ffmpeg/issues/78 there are problems whenever spaces (and probably many other characters) are used in filenames. I don't see the need to "add quotes" for file paths, particularly if these are coming from a properly-formed string as would be the case with path.resolve("./some/folder/file with spaces etc.mp4".
In any case, the utils.addQuotes function currently uses JSON.stringify which is surely not intended for this use case. We don't want JSON, we want a path to pass to the command line.
I don't have access Windows machine now so I can't test whether this breaks anything on Windows, but I would assume path.resolve should give a perfectly valid filename path as a string, too.
As per https://github.com/damianociarla/node-ffmpeg/issues/78 there are problems whenever spaces (and probably many other characters) are used in filenames. I don't see the need to "add quotes" for file paths, particularly if these are coming from a properly-formed string as would be the case with
path.resolve("./some/folder/file with spaces etc.mp4"
.In any case, the
utils.addQuotes
function currently usesJSON.stringify
which is surely not intended for this use case. We don't want JSON, we want a path to pass to the command line.I don't have access Windows machine now so I can't test whether this breaks anything on Windows, but I would assume
path.resolve
should give a perfectly valid filename path as a string, too.