search

damianof / large-scale-apps-my-vue3-project

Companion code to the book "Large Scale Apps with Vue 3 and TypeScript"
MIT License
147 stars 32 forks source link

Running Sample "Up to Chapter 5" broken layout in Firefox #4

Closed scheinercc closed 3 years ago

scheinercc commented 3 years ago

https://largescaleapps.com/chapter5/#/

image

Tested with Firefox 88 (current Dev Edition; released in ~5 days: https://wiki.mozilla.org/Release_Management/Calendar) on macOS Big Sur 13.2.x

It seems this can be fixed by changing 

li.item {
  outline: ...
}

to 

li.item {
  border: ...
}
scheinercc commented 3 years ago

I also filed a ticket against Firefox in case there is something funny going on with the browser, but it doesn't seem like it. border seems to be the more solid choice: https://bugzilla.mozilla.org/show_bug.cgi?id=1705005#c1

damianof commented 3 years ago

Thank you for reporting this. Since the main goal of the book was not to support all browsers, I'll keep the outline for now and let the readers know that using border fixes the issue in Firefox.