search

damianopetrungaro / clean-architecture

Package for isolate your domain code from framework dependency using DDD concepts.
MIT License
96 stars 20 forks source link

Improve Enum #13

Closed bigfoot90 closed 6 years ago

bigfoot90 commented 6 years ago

Implement getValues() and is() methods.

bigfoot90 commented 6 years ago

Do you mean FixtureEnum::C()? I think that A and B and NUMBER are just enought for our simple test case.

bigfoot90 commented 6 years ago

@damianopetrungaro Should I revert tests?

damianopetrungaro commented 6 years ago

@bigfoot90 yup, it should be good.

damianopetrungaro commented 6 years ago

@bigfoot90 take a look here too: https://github.com/damianopetrungaro/clean-architecture/pull/13#discussion_r185739034

bigfoot90 commented 6 years ago

Codacy is falling, but it's talking about tests, I can't fix this.

damianopetrungaro commented 6 years ago

Could you please squash all the commits and use this convention to create the commit? @bigfoot90 removed Codacy access 😄

damianopetrungaro commented 6 years ago

@bigfoot90 great squash.

Just for my preference (PR it's really ok)

feat: Add equals and getAllowed methods to Enum

<Explain here why you add those changes>
bigfoot90 commented 6 years ago

Fixed equals method. It's ready for merge now.

damianopetrungaro commented 6 years ago

Thank you for your time and your patience @bigfoot90 ! Really appreciate your quick feedbacks 😄