damianszczepanik / cucumber-reporting-jenkins

Java jenkins plugin for cucumber-jvm reporting
151 stars 12 forks source link

cucumber-html-report fails to display feature overview graphs when there are any pending steps #64

Closed attr closed 9 years ago

attr commented 11 years ago

cucumber-html-report displays

    <div id="fullwidth_gradient">
        <div class="container_12">
            <div class="grid_9 heading">
                <h2 id="overview-title">Oops Something went wrong with ci-rnd-BDD-tests build: 147</h2>
                <span class="subhead">The error message (if any) is below:</span>
            </div>
        </div>
    </div>

    <div class="container_12">
        <div class="grid_12">

    <br>

    <div id="error-message" class="error-message">java.lang.NullPointerException</div>

instead of showing feature overview graphs when a pending step is introduced, i.e.:

@Then("^pending step$")
public void pendingStep() {
    throw new PendingException();
}

I`m using Jenkins v.1.515 with cucumber-reporting v.0.0.21 and cucumber-jvm v.1.1.3. Jenkins logs:

INFO: ci-rnd-BDD-tests #147 main build action completed: SUCCESS
java.lang.NullPointerException
        at net.masterthought.cucumber.ReportBuilder.getBuildStatus(ReportBuilder.java:63)
        at net.masterthought.jenkins.CucumberReportPublisher.perform(CucumberReportPublisher.java:114)
        at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:19)
        at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804)
        at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:776)
        at hudson.model.Build$BuildExecution.post2(Build.java:183)
        at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:726)
        at hudson.model.Run.execute(Run.java:1600)
        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
        at hudson.model.ResourceController.execute(ResourceController.java:88)
        at hudson.model.Executor.run(Executor.java:241)
kingsleyh commented 11 years ago

Ok thanks for spotting this - fixes will be in the next release

Sent from my iPhone

On 3 Jun 2013, at 13:01, attr notifications@github.com wrote:

cucumber-html-report displays

<div id="fullwidth_gradient">
    <div class="container_12">
        <div class="grid_9 heading">
            <h2 id="overview-title">Oops Something went wrong with ci-rnd-BDD-tests build: 147</h2>
            <span class="subhead">The error message (if any) is below:</span>
        </div>
    </div>
</div>

<div class="container_12">
    <div class="grid_12">

<br>

<div id="error-message" class="error-message">java.lang.NullPointerException</div>

instead of showing feature overview graphs when a pending step is introduced, i.e.:

@Then("^pending step$") public void pendingStep() { throw new PendingException(); } I`m using Jenkins v.1.515 with cucumber-reporting v.0.0.21 and cucumber-jvm v.1.1.3. Jenkins logs:

INFO: ci-rnd-BDD-tests #147 main build action completed: SUCCESS java.lang.NullPointerException at net.masterthought.cucumber.ReportBuilder.getBuildStatus(ReportBuilder.java:63) at net.masterthought.jenkins.CucumberReportPublisher.perform(CucumberReportPublisher.java:114) at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:19) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:776) at hudson.model.Build$BuildExecution.post2(Build.java:183) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:726) at hudson.model.Run.execute(Run.java:1600) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:241) — Reply to this email directly or view it on GitHub.

kingsleyh commented 11 years ago

fixed in pending release

meredrica commented 11 years ago

Any idea when you will release this? last release is 6 months ago.

sherl0cks commented 10 years ago

Any update on the release to fix this issue?

For anyone that stumbles upon this issue, a simple work around is to leave the step completely unimplemented instead of writing the method signature and throwing the PendingException(). The plugin will properly render this scenario and still record the unimplemented steps as pending.

plopez-bmj commented 10 years ago

As I said in this other issue https://github.com/masterthought/jenkins-cucumber-jvm-reports-plugin-java/issues/65 a possible workaround until the bugfix is released is to add a post-build step in Jenkins to fix the Json files before the report is generated. Hope this helps.

damianszczepanik commented 9 years ago

Released