damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
543 stars 402 forks source link

Remove dependency to commons-collections4 #1097

Closed lvogt closed 1 year ago

lvogt commented 1 year ago

When the commons-colllections dependency was updated to v4 the only(!) used import was updated wrongly. This resulted in NoSuchMethods exception in certain classpath configurations.

[...]
Caused by: java.lang.NoSuchMethodError: 'boolean org.apache.commons.lang3.ObjectUtils.isNotEmpty(java.lang.Object)'
        at net.masterthought.cucumber.ReportParser.parseClassificationsFiles(ReportParser.java:129)
        at net.masterthought.cucumber.ReportBuilder.generateReports(ReportBuilder.java:94)
[...]

I suggest to simply drop the dependency completely, as it is only used a single time.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1097 (22dddd3) into master (55482de) will decrease coverage by 0.09%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1097      +/-   ##
============================================
- Coverage     97.19%   97.10%   -0.09%     
- Complexity      553      554       +1     
============================================
  Files            55       55              
  Lines          1211     1211              
  Branches        106      106              
============================================
- Hits           1177     1176       -1     
  Misses           20       20              
- Partials         14       15       +1     
Impacted Files Coverage Δ
.../java/net/masterthought/cucumber/ReportParser.java 98.33% <0.00%> (-1.67%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more