search

damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
543 stars 402 forks source link

Merge request for implementing new test cases and refactoring code smells #1118

Closed harshpreet08 closed 8 months ago

harshpreet08 commented 9 months ago

I am a Dalhousie University graduate student wanting to contribute to your project. I have implemented several new test cases (6 in total) which increase the code coverage (method, line and branch coverage). I have made sure that these test cases are non trivial and actually enhance the overall coverage. Also, I have refactored the code to get rid of implementation and design smells (3 implementation and 4 design) to improve cohesiveness and readability of the code.

I request you to kindly approve the pull request. If you find that there are other changes that need to be made, please let me know. Hoping for a preempt response.

Amazing repo to work on especially due to almost all methods being covered in the existing tests.

damianszczepanik commented 9 months ago

Nice to see such intentions however it's hard to evaluate code coverage because it does not even pass tests you have updated.

Second: you are introducing many small changes here, some good, some not clear to me, others won't acceptable. If you want contribute split all changes into small PR so I can easily review them. Rebase the code first.