Closed hazendaz closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.51%. Comparing base (
019385d
) to head (38f697f
). Report is 5 commits behind head on master.:exclamation: Current head 38f697f differs from pull request most recent head e5c7160
Please upload reports for the commit e5c7160 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is great job to have it merged. Can you split this into smaller PR so I can easily review them one by one ?
Thanks, will be maybe a week to get back to this but will break it up for you in smaller commits.
keeping open for moment but splitting out into smaller PRs as noted as well as rebased against master.
@damianszczepanik For now I sent as much to review as feasible for the moment. Some of what I did not send requires some of the other items to be in place. If you could review those when you have time, as merged I will rebase this branch until such time its cleared out. Its otherwise just for reference now. When done, I'll move forward and upgrade to full junit 5 jupiter here too.
I did see you added dependabot, I would suggest Renovate as a much better alternative. Dependabot will still get used in some regard for security alerts but Renovate now also supports those too and dependabot will fail to find all. If not familar with Renovate, please check out this repo of mine that has a lot of PRs on it as well as a dependency issue tracker that shows what the repo has going on. Its a more advanced config setup as I'm getting ready to split that said repo between javax and jakarta namespaces so I have it running twice on 2 different branches for that longer term need. Renovate dashboard https://github.com/psi-probe/psi-probe/issues/2205 and see open PRs https://github.com/psi-probe/psi-probe/pulls to get an idea on how that one works.
You can find renovate in the marketplace!
going to close this one as it was for tracking and these can start coming in normally at this point.
In an effort to get rid of libraries coming into code bases that are long obsolete, coming here to the source for us to clear these out. This is somewhat big pull request. Each item has been constructively broken down into individual commits. All tests continue to pass. This can be further broken down if wished into smaller PRs.
General list of items
As to powermock, it is obsolete too except for its whitebox which is still extremely useful but there is no activity there. If this goes well, I don't mind upgrading this repo to junit 5 jupiter as well with mockito and replacing all the major parts of powermock as well. As to extra throws with powermock reflect, that is sort of needed here since jmockit, since I toke it over, does not yet have deencapsulation back (but that is in flight) and it should only be considered maintenance anyways. While there are other solutions out there, powermocks whitebox still seems best there and it can be isolated to just that module rather than how it is today. Other than that, I think rest would be fairly modern here, still java 8 compatible, and now shows java 21 compatibility.