[test] Use commons text for parts extracted from commons-lang since 3.5

damianszczepanik / cucumber-reporting

HTML reports for Cucumber

GNU Lesser General Public License v2.1

543 stars 402 forks source link

[test] Use commons text for parts extracted from commons-lang since 3.5 #1131

Closed hazendaz closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (91dfed3) 97.11% compared to head (f06a6ce) 97.11%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1131 +/- ## ========================================= Coverage 97.11% 97.11% Complexity 555 555 ========================================= Files 55 55 Lines 1212 1212 Branches 106 106 ========================================= Hits 1177 1177 Misses 20 20 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

damianszczepanik commented 8 months ago

Can you add context for this change ? What is the aim of this?

hazendaz commented 8 months ago

See https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/text/package-summary.html as straight from javadocs.

As of 3.6+ all the commons text items have been deprecated and were split out to commons-text. Initially commons text had a hard dependency on commons-lang3 but I believe that is now no longer the case.

For escapeHtml it was further split into 2 pieces. html4 or html5. I went with the the lower due to already present issues with libraries well out of date which means it would have been html4 already. However it could move to html5 on separate pull request.

damianszczepanik commented 8 months ago

Can you rebase rest PR to new pom.xml version ?

hazendaz commented 8 months ago

Can you rebase rest PR to new pom.xml version ?

done.