search

damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
543 stars 402 forks source link

Add test for getExtension method in Embedding class #1134

Closed harshpreet08 closed 8 months ago

harshpreet08 commented 8 months ago

Pull Request Summary

This pull request introduces a new test case in the EmbeddingTest class, specifically in the getExtension method. The test, named getExtension_UsesExtensionFromNameWhenMIMETypeIsUnknown, verifies that the method correctly retrieves the file extension from the name when the MIME type is unknown. This improvement makes sure our code handles unknown file types more effectively and adds to the overall coverage of our code tests.

Your review of the changes is appreciated. Thank you!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7375184) 97.11% compared to head (410833f) 97.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1134 +/- ## ========================================= Coverage 97.11% 97.11% Complexity 555 555 ========================================= Files 55 55 Lines 1212 1212 Branches 106 106 ========================================= Hits 1177 1177 Misses 20 20 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

damianszczepanik commented 8 months ago

Nice test!