Closed harshpreet08 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7375184
) 97.11% compared to head (410833f
) 97.11%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice test!
Pull Request Summary
This pull request introduces a new test case in the
EmbeddingTest
class, specifically in thegetExtension
method. The test, namedgetExtension_UsesExtensionFromNameWhenMIMETypeIsUnknown
, verifies that the method correctly retrieves the file extension from the name when the MIME type is unknown. This improvement makes sure our code handles unknown file types more effectively and adds to the overall coverage of our code tests.Your review of the changes is appreciated. Thank you!