damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
543 stars 402 forks source link

Upgrade to commons configuraton 2 and adjust location of dependencies for clarity (compile vs test) #1141

Closed hazendaz closed 8 months ago

hazendaz commented 8 months ago

Original commons configuration had dependency on commons bean utils which is used by a test case via sun proxy. Set that as test scope. Moved the compile scoped commons items up to area with other commons to be clear what is test vs compile scope.

Note duplicate keys cannot generally occur in newer version but a test is expecting it so code added to allow such a condition to occur. That may need to be removed instead and test removed. General idea here though was to handle exactly as it does right now.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (95af579) 97.11% compared to head (e716fe5) 97.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1141 +/- ## ========================================= Coverage 97.11% 97.11% - Complexity 555 556 +1 ========================================= Files 55 55 Lines 1212 1214 +2 Branches 106 105 -1 ========================================= + Hits 1177 1179 +2 Misses 20 20 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.