search

damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
548 stars 403 forks source link

Skipped steps leads to failed scenario #629

Closed lbovet closed 7 years ago

lbovet commented 7 years ago

When a single step is skipped, the scenario (and feature) is rendered as failiing. Would it not be correct to allow skipped steps in a scenario? (e.g. via a configuration flag)

damianszczepanik commented 7 years ago

You can configure final result but this case is implemented by design

lbovet commented 7 years ago

"You can configure final result", you mean it is already possible to consider skipped tests as non-failing?

damianszczepanik commented 7 years ago

https://github.com/damianszczepanik/cucumber-reporting/blob/master/src/main/java/net/masterthought/cucumber/ReportResult.java#L64

lbovet commented 7 years ago

Would you accept a PR allowing to specify in the Configuration which statuses are considered as success? Default would be as it is today (only passed). Additionally, this should be checkbox-configurable in the jenkins plugin as well. (another PR in jenkins plugin project).

damianszczepanik commented 7 years ago

I'm not hap[y about it because the PR you are talking about is the way how old cucumber was working and it was quite confusing for users. Tell me how would you like to manager not passing statuses that should be marked as passing?