search

damianszczepanik / cucumber-reporting

HTML reports for Cucumber
GNU Lesser General Public License v2.1
548 stars 403 forks source link

cucumber jvm embedded image not shown/attached to report #668

Closed a1dutch closed 7 years ago

a1dutch commented 7 years ago

Hi Im using cucumber jvm 2.0.1 & selenium 3.6.0 and my embedded screenshots are not getting attached to the report, i think the difference/problem is that https://github.com/damianszczepanik/cucumber-reporting/blob/master/src/test/resources/json/sample.json has embeddings and in my json file they are under embedding so are not getting parsed correctly.

Not sure if this should be reported here, cucumber or selenium.

Cheers

Andy

a1dutch commented 7 years ago

just found this is anyone has hit the same problem https://github.com/cucumber/cucumber-jvm/issues/1235

damianszczepanik commented 7 years ago

Let's wait for their feedback. I can implement additional https://github.com/damianszczepanik/cucumber-reporting/tree/master/src/main/java/net/masterthought/cucumber/json/deserializers to make support for both versions but in that case I introduce some kind of code smell into my project. This makes me worry.

a1dutch commented 7 years ago

i've managed to work round it locally, i just do a find/replace inside the json files. i merge my json files as a pre step before passing the merged json file into this library.