search

damianszczepanik / cucumber-sandwich

Create Pretty Cucumber Reports on the Fly locally during development
60 stars 31 forks source link

Classifications via properties files #52

Closed bhreinb closed 6 years ago

bhreinb commented 6 years ago

When I cloned the repo a few weeks ago it was set to 3.15

Since then (10 days ago) you upgraded the dependency to 3.16

https://github.com/damianszczepanik/cucumber-sandwich/blob/master/pom.xml

So I aligned the dependency to what you currently set. Make sense?

damianszczepanik commented 6 years ago

It does. The real question was why did you not rebase the code before sending pull request. Do this then send changes again

bhreinb commented 6 years ago

Apologies, I didn't do a rebase as the only file that changed within the 10 days from your commit was

https://github.com/damianszczepanik/cucumber-sandwich/commits/master/pom.xml

which was upgrading the dependency version & updating the version of the library. I have aligned that manually so hopefully the PR is good for you.

damianszczepanik commented 6 years ago

Closing the PR as the rebase is still not performed properly

bhreinb commented 6 years ago

I submitted the PR with the changes...pity their wasn't any flexibility on your part on accepting it.

damianszczepanik commented 6 years ago

It was not ready to be merged and hasn't been updated for over 7 months.

bhreinb commented 6 years ago

I disagree 7 months ago it was ready. Correct it hasn't been touched since.