Support for parametrised build number

[alborworld]

Hi, I have noticed that the build number is always set to one. Looking at the code, it's hardcoded.

It's seems to be pretty straightforward to add an optional parameter to specify it - that could be useful for instance in the case the CI tool (e.g. Jenkins, TeamCity, etc.) provides the build number, that we want to see in the report.

@kingsleyh I have implemented the changes. Could you have a look?

[kingsleyh]

Sure go ahead and send a pull request

Sent from my iPhone

On 14 Jun 2014, at 12:55, alborworld notifications@github.com wrote:

Hi, I have noticed that the build number is always set to one. Looking at the code, it's hardcoded.

It's seems to be pretty straightforward to add an optional parameter to specify it - that could be useful for instance in the case the CI tool (e.g. Jenkins, TeamCity, etc.) provides the build number, that we want to see in the report.

I can also contribute to the coding, it's probably about adding a couple of lines of code.

— Reply to this email directly or view it on GitHub.

[alborworld]

@kingsleyh Apparently I don't have the right permissions to push...

Username for 'https://github.com': alborworld Password for 'https://alborworld@github.com': remote: Permission to masterthought/maven-cucumber-reporting-mojo.git denied to alborworld. fatal: unable to access 'https://github.com/masterthought/maven-cucumber-reporting-mojo.git/': The requested URL returned error: 403

[kingsleyh]

You can't push but you can send me a pull request

Sent from my iPhone

On 14 Jun 2014, at 14:01, alborworld notifications@github.com wrote:

@kingsleyh Apparently I don't have the right permissions to push...

Username for 'https://github.com': alborworld Password for 'https://alborworld@github.com': remote: Permission to masterthought/maven-cucumber-reporting-mojo.git denied to alborworld. fatal: unable to access 'https://github.com/masterthought/maven-cucumber-reporting-mojo.git/': The requested URL returned error: 403

— Reply to this email directly or view it on GitHub.

[alborworld]

@kingsleyh Done.

[alborworld]

@kingsleyh I noticed you've accepted the pull request. Are you going to release it soon? Thanks.

[woodybrood]

Was this ever used/released? I see a buildNumber parameter in the code, but when I try to use it, the build number never changes.

<plugin>
            <groupId>net.masterthought</groupId>
            <artifactId>maven-cucumber-reporting</artifactId>
            <version>0.0.6</version>
            <executions>
                <execution>
                    <id>execution</id>
                    <phase>test</phase>
                    <goals>
                        <goal>generate</goal>
                    </goals>
                    <configuration>
                        <projectName>cfw</projectName>
                        <outputDirectory>${cucumberReportDestination}/cucumber-html-reports</outputDirectory>
                        <cucumberOutput>${project.build.directory}/cucumber.json</cucumberOutput>
                        <enableFlashCharts>false</enableFlashCharts>
                        <buildNumber>${bambooBuildNumber}</buildNumber>
                    </configuration>
                </execution>
            </executions>
        </plugin>

[damianszczepanik]

Released, time ago