search

damianszczepanik / maven-cucumber-reporting

maven mojo for cucumber reporting
GNU Lesser General Public License v2.1
122 stars 111 forks source link

Not considering about failing scenarios or features #200

Closed deivydasp closed 2 years ago

deivydasp commented 3 years ago

Hi @damianszczepanik , noticed one problem with plugin. Build result is not changed to "Failed" when Before/After hooks fails. This situation happens because if statement, which determine when to fail the build, not taking into account failed scenarios/features.

Before: image After: image In both cases Build was successful, maybe there is an option to fix that?

damianszczepanik commented 3 years ago

I believe you can tune your results https://github.com/damianszczepanik/maven-cucumber-reporting/blob/master/src/main/java/net/masterthought/cucumber/CucumberReportGeneratorMojo.java#L224

deivydasp commented 3 years ago

How I can tune my results if 224 line not taking into account failed scenarios/features? if you take a look into my screenshots there is no failed/pending/undefined steps.

damianszczepanik commented 3 years ago

True, you can add support for values which you are looking for and prepare PR so then I will merge it