damien-rivet / JamfKit

A Jamf Classic communication framework written in Swift
MIT License
41 stars 1 forks source link

Implement Computer group model #57

Closed damien-rivet closed 6 years ago

damien-rivet commented 6 years ago

Implements #31.

Refactored MobileDeviceGroup / ComputerGroup classes. Added HardwareGroup base class. Moved / renamed matching tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #57 into develop will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
+ Coverage    98.49%   98.53%   +0.03%     
===========================================
  Files           33       35       +2     
  Lines          999     1022      +23     
===========================================
+ Hits           984     1007      +23     
  Misses          15       15
Impacted Files Coverage Δ
...Kit/Sources/Models/MobileDevice/MobileDevice.swift 100% <100%> (ø) :arrow_up:
...t/Sources/Models/HardwareGroup/HardwareGroup.swift 100% <100%> (ø)
.../Models/HardwareGroup/HardwareGroupCriterion.swift 100% <100%> (ø)
...s/Models/MobileDeviceGroup/MobileDeviceGroup.swift 100% <100%> (ø) :arrow_up:
...t/Sources/Models/ComputerGroup/ComputerGroup.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b61173c...6739350. Read the comment docs.