Closed mikeandersun closed 7 years ago
Hi Mike
Here's and example net461, supported by netstandard1.4: https://github.com/damienbod/WebSearchWithElasticsearch (check the packages to see what's needed)
Here's a .net core app https://github.com/damienbod/WebAppAspNet50ElasticsearchCrud
net451 will not be supported.
net452, undecided about this, these apps could be updated to net461
My main reason was that it's too much work to support two versions, and I assume in 6 months most will have switched to net462, net463 or net core.
What do you require, suggest?
Greetings Damien
Hi Damien,
I require make frameworks
section of project.json
as below:
"frameworks": {
"net451": {},
"net452": {},
"net46": {},
"netcoreapp1.6": {
"imports": [
"dnxcore50",
"portable-net45+win8"
]
}
}
Ok, I'll see what I can do, net451 should be removed as this is no longer a supported .NET. netcoreapp1.6 should be no problem, net46 and net452, I need to check.
Greetings Damien
Thanks.I'm waiting for your decision. It is better to have a gitter to chat.
Please add NuGet.Config
to repo.
Ok, net451 and net 452 causes to many type conflicts.
"frameworks": {
"netstandard1.4": {
"imports": [
"dnxcore50",
"portable-net45+win8"
],
"dependencies": {
"Newtonsoft.Json": "9.0.1",
"System.ComponentModel.Annotations": "4.1.0",
"System.Net.Http": "4.1.0",
"System.Reflection.TypeExtensions": "4.1.0",
"System.Console": "4.0.0",
"System.Diagnostics.TraceSource": "4.0.0"
}
},
"netcoreapp1.6": {
"imports": [
"dnxcore50",
"portable-net45+win8"
],
"dependencies": {
"Newtonsoft.Json": "9.0.1",
"System.ComponentModel.Annotations": "4.1.0",
"System.Net.Http": "4.1.0",
"System.Reflection.TypeExtensions": "4.1.0",
"System.Console": "4.0.0",
"System.Diagnostics.TraceSource": "4.0.0"
}
},
"net46": {
"dependencies": {
"Newtonsoft.Json": "9.0.1",
"System.ComponentModel.Annotations": "4.0.10.0",
"System.Net.Http": "4.1.0",
"System.Reflection.TypeExtensions": "4.1.0",
"System.Console": "4.0.0",
"System.Diagnostics.TraceSource": "4.0.0"
}
}
}
I'll create a beta version, I have to test.
I made a mess of the integration tests and need to change these all back NUnit, then I can run quicker for all configurations.
Do we still need a NuGet.config?
The first test aren't working, this will take time, I will create a new branch for this, strange effects with the VS tooling...
Greetings Damien
No, You can remove it (Nuget.config
) from the solution too.
netstandard1.4 covers net461 and higher. https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md