search

damienbod / angular-auth-oidc-client

npm package for OpenID Connect, OAuth Code Flow with PKCE, Refresh tokens, Implicit Flow
https://www.npmjs.com/package/angular-auth-oidc-client
MIT License
1.15k stars 434 forks source link

[Bug]: why does id token expiry check performs during silent refresh #1391

Closed nishadthajudeen001 closed 1 year ago

nishadthajudeen001 commented 2 years ago

What Version of the library are you using? Version11

Describe the bug Why do we check hasIdTokenExpired during silent token refresh? can we avoid this check since we dont really need this once app is logged in. Only access token is refreshed silently to authenticate the APIs periodically-token-check.service.ts - const idTokenHasExpired = this.authStateService.hasIdTokenExpired();

This is for Angular SPA app with implicit flow

nishadthajudeen001 commented 2 years ago

shall we add a PR with a new OpenIdConfiguration to exclude this check in version11? please advise

nishadthajudeen001 commented 2 years ago

@damienbod did you get a chance to check this?

nishadthajudeen001 commented 2 years ago

@damienbod gentle reminder on this ask.

damienbod commented 2 years ago

This should be fixed in version 13, can you update?

Greetings Damien

nishadthajudeen001 commented 2 years ago

@damienbod Sorry for the late reply. does version 13 has dependency with Angular 13? can we use this version with Angular11 APP?

damienbod commented 2 years ago

yes

FabianGosebrink commented 1 year ago

Closing as there hasn't been any response from the issue author. Please re-open if you are still seeing problems here.