search

damienchambe / metabase-db2-driver

AS400 / IBM i DB2 Driver for Metabase
Eclipse Public License 2.0
15 stars 0 forks source link

Update driver for metabase 0.46 #4

Open damienchambe opened 1 year ago

damienchambe commented 1 year ago

Old methods are deprecated and the build process is changed. Update to newer methods and test with 0.46

rcronin commented 1 year ago

I'm glad I checked your repository as I've been doing the same thing with my fork. I ran into an issue with setting date parameters. This fixed it:

(defmethod sql-jdbc.execute/set-parameter [:iseries OffsetDateTime] [driver ps i t] (sql-jdbc.execute/set-parameter driver ps i (t/sql-timestamp (t/with-offset-same-instant t (t/zone-offset 0)))))

damienchambe commented 1 year ago

@rcronin I didn't notice the problem, thanks I will check and use your code

rcronin commented 1 year ago

@damienchambe - could you try to reproduce an issue I’m seeing please?

create a new question via sql with a timestamp and time type column exposed. Then try to explore that question and filter on both columns. Are you able to get the relative date/time filters to work?

I’m getting an invalid cast/data type mismatch error