damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.
12 stars 6 forks source link

Media Logos - fill some gaps and make more accurate use of other Media Logos. #1030

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This patch increases the number of MediaPortal media logos used by Moving 
Pictures, as I found I has gaps for some formats and some weren't described as 
accurately as the icons supplied with MediaPortal would allow.

An example is that Dolby TrueHD was not picked up and all films with DTS just 
used the DTS icon when DTS 96/24, DTS ES, DTS HDMA and DTS HDHR were also 
avaliable. 6.1 sound also left a gap. Looking at the code I am guessing this 
was left to enhance at a later date, which is what I am trying to achieve. I 
certainly haven't covered every format, just those I had to hand and could 
identify with MediaInfo, and I feel it makes the situation better.

I have amended the code in line with the existing identification of formats so 
they are loaded into the local_media table and match the icon names. I have 
tested them with the formats and the icons now appear correctly. I am new to C# 
so hope I have done this OK and not broken something else.

Thanks

Mew

Original issue reported on code.google.com by mark.wil...@googlemail.com on 4 Jul 2011 at 8:44

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks Mew! I will take a look at this in the next few days and try to get it 
included in our next release.

Original comment by conrad.john on 5 Jul 2011 at 12:53

GoogleCodeExporter commented 9 years ago
Patch looks good Mew but I am going to move this to 1.3 because it will 
generate changes for skinners and I really don't like including that sort of 
stuff in a maintenance release like 1.1.5 / 1.2.3.

Original comment by conrad.john on 30 Jul 2011 at 4:13

GoogleCodeExporter commented 9 years ago
That's fine, I understand that changes that could upset the status quo need to 
be left for big releases where skinners have notice of the changes.

The change is designed to fill gaps in the line of media icons using those 
currently available in the DefaultWide skin (such as 6.1 audio). I have had a 
look at the Backdrop skin and this appears to use the same names for the Logo 
icons as DefaultWide but I guess all skins might not. They may need to be 
amended to include either additional icons or copies of existing ones with new 
file names.

Original comment by mark.wil...@googlemail.com on 2 Aug 2011 at 8:24

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 30 Dec 2011 at 6:50

GoogleCodeExporter commented 9 years ago

Original comment by damien.haynes@gmail.com on 12 Jan 2014 at 8:27