damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.
12 stars 6 forks source link

TV Series Listed In Result Set (with quotes?) #106

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create dummy file: f:\MEDIA\Movies\Happy Go Lucky (2008)\Happy.Go.Lucky.
[2008.Eng].DVDRip.DivX-LTT.avi
2. the movie name fetched from imdb is: (exact name) "Happy Go Lucky" 2005
3. The sorting will be wrong because of " character, wrong movie has been 
selected.

What is the expected output? What do you see instead?
First " character should be ignored. There are LOTS of movies which have 
by error quotation marks in the name of the movie. This needs to be 
stripped somehow.

What version of Moving Pictures are you using? What version of MediaPortal?
Current SVN

Original issue reported on code.google.com by pira...@gmail.com on 16 Sep 2008 at 11:01

GoogleCodeExporter commented 9 years ago
confirmed.. little mistake in punctuation filter... will correct this.

Original comment by apond...@gmail.com on 17 Sep 2008 at 8:11

GoogleCodeExporter commented 9 years ago
this filtering logic is in the MovieImporter btw. It cleans the results for
levenhstein matching only.

Original comment by apond...@gmail.com on 17 Sep 2008 at 8:12

GoogleCodeExporter commented 9 years ago

Original comment by apond...@gmail.com on 17 Sep 2008 at 8:13

GoogleCodeExporter commented 9 years ago
I committed a fix for the actual matching but i leave the issue open for fforde 
to
decide wether these quotation marks needs fixing in the scraper also. I think 
in some
cases they need to be removed (like your example).

Original comment by apond...@gmail.com on 17 Sep 2008 at 8:20

GoogleCodeExporter commented 9 years ago
The quotes are because that particular match is not a movie it is an entire TV 
Series. Looking a little into IMDB, it looks like all TV Series names are 
quoted. I 
agree this should be stripped off, however I also feel TV Series should not be 
a part 
of the result set. TV Movies yes. TV Series no. So I will modify the scraper to 
exclude TV Series in the search results.

Original comment by conrad.john on 17 Sep 2008 at 2:46

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 19 Sep 2008 at 2:00

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 20 Sep 2008 at 9:17

GoogleCodeExporter commented 9 years ago

Original comment by apond...@gmail.com on 26 Sep 2008 at 12:09

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 16 Oct 2008 at 3:25

GoogleCodeExporter commented 9 years ago
That still appears to have a problem:
f:\MEDIA\Movies\Masters of Horror. The Screwfly Solution (2006)\Masters of 
Horror. 
The Screwfly Solution (2006).avi
NFO file containing   http://www.imdb.com/title/tt0833098/ 

added with quotation marks:
"Masters of Horror" The Screwfly Solution
Sorting is broken, the movie appears as the first one in the list.

Original comment by pira...@gmail.com on 22 Oct 2008 at 5:19

GoogleCodeExporter commented 9 years ago

Original comment by apond...@gmail.com on 22 Oct 2008 at 5:44

GoogleCodeExporter commented 9 years ago
As we officially do not support TV Shows right now, and as there is a very easy 
work 
around (just modify the sort by field in the GUI), I think this sorting issue 
should 
be split off into it's own issue and scheduled for a later release. We are 
rushing to 
get things out the door. 

This is not the best time to work on low priority issues that relate to 
unsupported 
content.

Original comment by conrad.john on 22 Oct 2008 at 6:15

GoogleCodeExporter commented 9 years ago
Sure it can wait for later. It's nowhere even close to urgent :)

Original comment by pira...@gmail.com on 22 Oct 2008 at 6:28

GoogleCodeExporter commented 9 years ago
Reclosing this issue, the "translated" request is splitted to Issue 164

Original comment by apond...@gmail.com on 22 Oct 2008 at 6:33