Closed GoogleCodeExporter closed 8 years ago
[deleted comment]
Original comment by damien.haynes@gmail.com
on 29 Feb 2012 at 10:20
Done the bulk of this in r1366. A few small things to do:
1. add new entry into dynamic filter dropdown
2. ensure default sort order of letters make sense for non-english locales.
3. upgrade tasks?
Original comment by damien.haynes@gmail.com
on 29 Feb 2012 at 1:40
Looking good. :) FYI on your todo list item #2 is Issue #715 here on the
tracker. I think adding the new node to both the Filter menu and the
MovieManager menu makes sense as well.
As far as upgrades, I kind of wish we had been tracking if a user makes changes
to their menu or not. For people that have never tweaked it it would be no big
deal to add something new IMO. But for people who have a custom setup it might
be annoying for them to have something new added without confirmation or
anything...
Any thoughts how to approach that?
Original comment by conrad.john
on 29 Feb 2012 at 8:34
I hope you don't mind, in r1367 I adjusted the labeling and position of the new
dynamic category on the default menus. I also adjusted things so that you can
select "Title" in the dynamic filter drop down to get this new filter (#1 on
your list).
Original comment by conrad.john
on 29 Feb 2012 at 11:25
That's good fforde, I dont mind.
Im not sure about the upgrade task, you make a good point in that someone could
get annoyed at the fact a new entry suddenly appears. I think just making it
clear in release notes that the new dynamic filter exists and how to add it if
user chooses.
Original comment by damien.haynes@gmail.com
on 1 Mar 2012 at 12:46
In r1371 I fixed a bug introduced in my last commit.
Original comment by conrad.john
on 3 Mar 2012 at 2:37
Original issue reported on code.google.com by
conrad.john
on 3 Feb 2012 at 3:14