Add Accept-Language header support for better results on sites like IMDb - Githubissues

damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.

12 stars 6 forks source link

Add Accept-Language header support for better results on sites like IMDb #1115

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

1. add accept-language support and auto populate with the script's specified 
language
2. add a property to retrieve node to forcefully override this

Original issue reported on code.google.com by RoChess....@gmail.com on 11 Feb 2013 at 4:05

GoogleCodeExporter commented 8 years ago

Original comment by conrad.john on 11 Feb 2013 at 4:06

Changed state: Accepted
Added labels: Component-Cornerstone, Priority-High, Type-Enhancement
Removed labels: Priority-Medium, Type-Defect

GoogleCodeExporter commented 8 years ago

Original comment by conrad.john on 11 Feb 2013 at 4:08

Changed title: Add Accept-Language header support for better results on sites like IMDb

GoogleCodeExporter commented 8 years ago

Created a patch for this – this will not solve the imdb issue though, as they 
seemingly went on to require accept-language: en-gb …

Original comment by goo...@chron.visiondesigns.de on 14 Feb 2013 at 8:53

Attachments:

patch

GoogleCodeExporter commented 8 years ago

Sorry, I meant to get this into 1.5.1. It will go into the next release.

Original comment by conrad.john on 25 Feb 2013 at 10:05

Added labels: Milestone-1.5.2

GoogleCodeExporter commented 8 years ago

Here’s another patch that will make the IDMb script use accept-language: 
en-gb. This is what’s actually required for IMDb to return English movie 
titles.

Original comment by goo...@chron.visiondesigns.de on 4 Mar 2013 at 5:05

Attachments:

imdb.patch

GoogleCodeExporter commented 8 years ago

Ok, I surrender – imdb just went crazy. Here are my findings (I am in 
germany):

To get the english title for “Bean” (1997), I have to set accept-language: 
en-gb.
For “Paperman” (2012), I need to set accept-language: en.
For “Taken 2” (2012), I can’t get the english title at all (also tried 
en-us).

Using “en-gb, en” or something like that also doesn’t help at all. Imdb 
seems to only read the first one.

Original comment by goo...@chron.visiondesigns.de on 4 Mar 2013 at 4:59

GoogleCodeExporter commented 8 years ago

Original comment by damien.haynes@gmail.com on 10 Jan 2014 at 10:59

Added labels: Milestone-1.6.2
Removed labels: Milestone-1.5.2

GoogleCodeExporter commented 8 years ago

Original comment by damien.haynes@gmail.com on 11 Jan 2014 at 1:44

Added labels: Milestone-1.6.1
Removed labels: Milestone-1.6.2

GoogleCodeExporter commented 8 years ago

Although the patch is out-dated I have managed to pull what I need from it so 
thanks.

This is worth committing on the basis it doesn't break existing scrapers i.e. 
it checks if the accept_header is null so it would seem nothing will change 
unless scrapers explicitly set it.

Will commit this, and look at possibly improving the default IMDb script after 
testing.

Original comment by damien.haynes@gmail.com on 11 Jan 2014 at 10:13

Changed state: FixedCompleted