search

damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.
12 stars 6 forks source link

Improve logging #1165

Closed doskabouter closed 4 years ago

damienhaynes commented 4 years ago

Hi @doskabouter , would you like to resolve the conflict for this.

doskabouter commented 4 years ago

Done. Perhaps you can do something more with this error instead of just logging (f.e. show to the user, or remove the entry from the list of movies?)

damienhaynes commented 4 years ago

Looks good.

With respect to you comment regarding doing something when there is an error...I believe there is some code which checks the return result of UpdateMediaInfo() and pops up a dialog if scanning in Configuration manually (not 100% sure on this as would require closer analysis).

Having said that, shouldn't we check the stream counts before attempting to get the individual properties and return error ?

fyi, the filters in the MovPics configuration Movie Manager pane allows you to filter movies with missing MediaInfo, this can be useful in rescanning movies which failed MI retrieval.

doskabouter commented 4 years ago

I didn't get any popups for my corrupt file, and it used to have mediainfo (when I first scanned it a long time ago it wasn't corrupt), so filters were no use for me. But as this is really a corner-case, I don't think any changes are really necessary...