search

damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.
12 stars 6 forks source link

Update to fix missing #selecteditem value for first movie in list for MediaPortal #1170

Closed KJ-Cox closed 2 months ago

KJ-Cox commented 2 months ago

Two changes to GUIFacadeControlExtensions.cs to allow the first movie in the list to populate the _listItems and have the information available for the titan skin to use.

damienhaynes commented 2 months ago

Thanks. It's been a while since I looked at this code so it's hard to review without debugging myself. But, it seems you are only fixing this for the categories facade (ID=51)? I presume everything was working as expected for the movie facade (ID=50)?

KJ-Cox commented 2 months ago

Thanks. It's been a while since I looked at this code so it's hard to review without debugging myself. But, it seems you are only fixing this for the categories facade (ID=51)? I presume everything was working as expected for the movie facade (ID=50)?

Thanks for getting back to me. Fixing this for the list of movies in any category, where if the selected movie on page load is the first item the value of #selecteditem is empty. When selecting another movie and back to the first the values are populated.

Note that in the two updated lines one is equal to 51 and the other is not equal to.

BTW, there is a discussion atm about unsupported plugins on MP forum and how to maintain support. If you would like to comment on the post it would mean a lot.

https://forum.team-mediaportal.com/threads/plugins-that-are-not-updated-by-the-author.141194/

KJ-Cox commented 2 months ago

FanartHandler plugin was changed to use #MovingPictures.SelectedMovie.title instead of #selecteditem and works perfectly. So this issue no longer affects what I needed.