Open GoogleCodeExporter opened 9 years ago
Like the idea!
But i don't think this quick patch is the way to go :) Thanks for your efforts
though.
We will probably do a complete DBMovie dump (in XML) so that the importer could
also
work offline (for movie data) much like MyMovies.
Original comment by apond...@gmail.com
on 20 Sep 2008 at 6:05
I agree, it's definitely a good idea and could save tons of time for people
when
rebuilding their database. I think your patch is a good start pirania, but I
think we
should dump a bit more information, using a structured file format (ideally
xml, like
armand suggested). If we do this in the future these files could be used as a
primary
data source for rescans, without the need to check online at all.
To see an example of iterating over all existing database fields of a
DBMovieInfo
object
see this code:
http://code.google.com/p/moving-
pictures/source/browse/trunk/MovingPictures/MainUI/MovingPicturesGUI.cs#923
Also the file name you generate will be a bad filename when the match contains
a pair
of
movies (cd1, cd2). This would need to be fixed. I think the name should be
identical
to
the first file in the match, but with an .NFO extension rather than .AVI or
whatever.
The existing extension should be truncated though. The code also needs to check
if
the
location is writable, it is possible that the disk could be read only.
And finally I would like to see an advanced setting that turns this off and on.
I
think
not everyone would want these files created, so they should have the
opportunity to
choose.
If you are willing to make some of these changes and clean things up that would
be
fantastic! Thanks for your contributions so far though. :)
Original comment by conrad.john
on 20 Sep 2008 at 6:16
Also, as I understand it, I think XBMC dumps similar files. We should either
mimic
this file format or use a different extension.
Original comment by conrad.john
on 20 Sep 2008 at 6:18
Yes, that was my idea.
You have to excuse me gentelment, but that was my first try in c# :) I said it
was
quick and dirty :P
Until now it was VB6, and things have advanced quite a lot as I see.
Hope to polish my skills up a little in C# and be a help for MovingPictures.
Your comments help a lot.
Original comment by pira...@gmail.com
on 20 Sep 2008 at 6:35
Hey, we are very glad to have the additional help! This project believe it or
not was
my first C# work as well. But I have been hacking this thing out for almost a
year
now, so I am starting to get used to C#. ;)
Original comment by conrad.john
on 20 Sep 2008 at 6:44
Any update on this pirania?
Original comment by conrad.john
on 16 Oct 2008 at 3:09
Sorry for the delay, but my vacation in Brazil took priority :)
I will try to put something more sophisticated during next weeks, and will
check
with you if you like it.
Original comment by pira...@gmail.com
on 22 Oct 2008 at 6:30
if pirania won't reclaim it, I'll have a go at it.
Original comment by marvenius@gmail.com
on 24 Nov 2008 at 10:29
Seperate issue but possible connection with Issue #230
Original comment by apond...@gmail.com
on 6 Dec 2008 at 8:00
Agree on the possible connection, some way that maybe a nfo produced with
Moving
pictures maybe have the nfo file list the artwork and the movie info. This
would
speed up rebuilds and aid the pages hosting the artwork and save time if you've
used
custom artwork/cover.
Original comment by smaug.th...@gmail.com
on 7 Dec 2008 at 9:34
My take on it went a little further than just making nfo for manually aproved
movies, more along the lines of making nfo for all movies. Should be optional
of
course. Personally i'd love it to generate nfo for all movies.
Nfo could contain:
Filename/Path
Imdb ID/(or other site id/url)
Artwork references
Text references (movie info, actors etc)
Mediainfo, maybe from mediainfo.dll
I realize this would possibly be a little much when you contemplate that the
plugin
is database driven allready. Just throwing the idea out there.
Original comment by smaug.th...@gmail.com
on 7 Dec 2008 at 9:43
Original comment by conrad.john
on 7 Dec 2008 at 8:00
Another point. I'm guessing it is not much more work, if any, to code the nfo
maker
to make for all movies vs just for movies manually imported. Would be kinda
wasted
not to enable it to do so for all movies when the issue is beeing adressed
anyways.
Original comment by smaug.th...@gmail.com
on 8 Dec 2008 at 3:02
Original comment by conrad.john
on 14 Dec 2008 at 6:20
Created the first go at it. Considering above proposals I came up with the
following:
Settings: * is default setting
- Create an NFO file True/False*
- Overwrite possible existing nfo files True/False* (nfo prefers %imdbid%.nfo,
but if
this is empty or non-existent falls back to %movietitle%.nfo)
- Format of nfo file basic txt only (limited data being written) Vs xml* thereby
closely mimicking the xbmc format.
This patch does not contain any option to trigger the action. This is just the
code.
You will probable need to create a button.
To be able to use these files in future rescans/rebuilds adjustments have to be
made
to the nfoscanner.
Original comment by marvenius@gmail.com
on 11 Feb 2009 at 9:01
Attachments:
I already use Media Companion, and I love that I can translate the IMDB info to
my
own language and when XBMC reads the scraper data I have the resume of the
movie in
my own laungage and with my own Poster cover !!! with maybee another titel than
the
one on IMDB (Many titles get translated to many laungages....)
So I see the NFO files as a pretty logic step....at leat give Media
portal/Moving
Pictures the posibility to read NFO files...
Original comment by h.casper...@gmail.com
on 29 Mar 2009 at 1:06
I already use Media Companion, and I love that I can translate the IMDB info to
my
own language and when XBMC reads the scraper data I have the resume of the
movie in
my own laungage and with my own Poster cover !!! with maybee another titel than
the
one on IMDB (Many titles get translated to many laungages....)
So I see the NFO files as a pretty logic step....at least give Media
portal/Moving
Pictures the posibility to read NFO files...
Original comment by h.casper...@gmail.com
on 29 Mar 2009 at 1:07
in the same ship very usefull store tags (covers, nfo, etc..) with the source
file to
share with all programs that wants to read movie info.
Original comment by tel...@gmail.com
on 28 Apr 2009 at 11:45
It's casually mentioned a few times above, but just to be clear, once we
implement
this, an NFO file should be written, and optionally a cover.jpg and
backdrop.jpg file,
to the directory the movie file is located in.
Original comment by conrad.john
on 28 Apr 2009 at 7:10
excellent! now what about folder.jpg as the cover instead so windows and other
programs will pick that up? is that an option?
Original comment by pgjensen
on 28 Apr 2009 at 7:45
It would almost certainly be configurable, similar to other stuff relating to
artwork
in the plugin. I know folder.jpg is standard, but I am just hesitant to use it
because
it would be clear as mud what the file contains. To me it's akin to someone
making a
forum post with the subject of "A quick question". Sure of course it's a
question, but
give it a meaningful name!
Anyway, yeah, it will either be folder.jpg or more likely it will be
configurable, but
with a different default.
Original comment by conrad.john
on 28 Apr 2009 at 7:52
sounds good as long as it's configurable to change the cover to folder.jpg :D
thanks
for the help!
Original comment by pgjensen
on 28 Apr 2009 at 7:55
Issue 497 has been merged into this issue.
Original comment by conrad.john
on 2 Aug 2009 at 4:41
Original comment by conrad.john
on 2 Aug 2009 at 4:41
Issue 514 has been merged into this issue.
Original comment by apond...@gmail.com
on 18 Aug 2009 at 9:39
Issue 540 has been merged into this issue.
Original comment by travistx
on 25 Sep 2009 at 11:33
Retagged the version number for this issue. This is not a rescheduling, we
are just changing our version number scale.
Original comment by conrad.john
on 29 Nov 2009 at 8:10
Original comment by conrad.john
on 29 Nov 2009 at 8:21
Issue 739 has been merged into this issue.
Original comment by conrad.john
on 19 Jan 2010 at 4:13
I hope the .nfo /.xml file created by moving pictures also includes watched
status,
and that when i watch a movie, moving pictures will update the .xml/.nfo file.
Everytime I reinstall mediaportal without backing up the database I loose all
this data.
Original comment by kiwijung...@gmail.com
on 25 Jan 2010 at 10:43
Original comment by conrad.john
on 31 Jan 2011 at 1:23
kiwijung...@gmail.com, there is trakt.tv / follw.it for this now... :)
Original comment by michel.zehnder
on 1 Feb 2012 at 7:41
Re: Folder.jpg as the cover
I prefer this because
1. When you browse folders in windows everything looks nice.
2. Some media extenders for example the WDTV Live Gen3 will display folder.jpg
when browsing shares
To differentiate between a proper movie cover and a windows generated
folder.jpg you could either
1. When MP creates folder.jpg it stores an EXIF tag inside the image,
identifying it as the movie cover, it could also optionaly store the imdb# in
an exif tag as well if it wanted to make sure the folder.jpg matches the
particular movie (probably not necessary)
2. When importing just look at the folder.jpg dimensions, if aspect ratio is ~
0.66 and heigh is > 800 pixels then YES this is a movie cover that I can import.
I prefer option #2 because I may want to manually drop better folder.jpg covers
in the movie folders, and would prefer it if moving pictures used these in
future scans.
Original comment by kiwijung...@gmail.com
on 31 May 2013 at 3:26
Original issue reported on code.google.com by
pira...@gmail.com
on 20 Sep 2008 at 4:44Attachments: