Closed GoogleCodeExporter closed 9 years ago
This sounds like a great feature, very helpfull for renaming a messy movie
collection once and for all. Maybe it could have an option for storing the
cover
image as folder.jpg in movie folder aswell, this would make remaking database
much
faster.
Original comment by smaug.th...@gmail.com
on 6 Dec 2008 at 7:43
This would also give moving pictures a feature no other plugin has, ability to
really sort your movies collection permanently. Would really give it the 5 star
quality it deserves. Maybe even an option to store the backdrop in movie folder
(by
users choosing, not everyone would like this option i guess).
Original comment by smaug.th...@gmail.com
on 6 Dec 2008 at 7:45
Seperate issue but possible connection with Issue #121
Original comment by apond...@gmail.com
on 6 Dec 2008 at 8:00
Maybe this is turning into a separate issue now, but an added bonus of storing
folder.jpg perhaps backdrop.jpg, will lighten the load on the pages hosting the
images and make offline database rebuild possible. As far as i remember, if a
movie
is deleted from the database the artwork is delted aswell?
Original comment by smaug.th...@gmail.com
on 6 Dec 2008 at 11:12
Yeah we can do this. It will have to be a ways out though, we have other things
that
I think should take priority.
Original comment by conrad.john
on 7 Dec 2008 at 7:40
I guess this issue would be solved by making the plugin rename the movie
file(s)
according to the database field wich holds the respective movie's name. Would
it be
possible to have an option to rename it with it's Imdb id aswell? like
TTxxxxx.avi.
After all its only just another field in the database.
Original comment by smaug.th...@gmail.com
on 13 Dec 2008 at 1:35
Original comment by conrad.john
on 14 Dec 2008 at 6:20
We could make it customizable. Everyone will want to have their stuff named
differently so it only makes sense.
Original comment by conrad.john
on 20 Dec 2008 at 10:02
In my opinion this should be a static thing that a user is able to do in the
config
and not an automatic change. My reasoning behind this is that the user could
opt to
change the file names for the movies currently in the DB once the user knows
that
they are all correct. This feature could have a negative impact if an incorrect
movie
is automatically assigned. This would cause the movie in the DB to be wrong and
also
the file name.
Original comment by LRFal...@gmail.com
on 26 Jan 2009 at 2:39
This should also look for subtitle files with the same name as the local file,
and
rename those so as not to break their relationship with the movie file.
Original comment by travistx
on 18 Apr 2009 at 1:18
like people before, i think this issue and Issue #121
are very interesting.
Original comment by tel...@gmail.com
on 28 Apr 2009 at 11:58
I agree with both LRfalk01 and Travis - these are both very crucial parts of
the
feature if it gets implemented.
Original comment by jona...@gmail.com
on 14 Sep 2009 at 1:25
It would be great it it could make also make file structures based on masks
similar to
how programs like media monkey do it.
Eg. %/%Name/%Name.avi
Original comment by tony...@gmail.com
on 27 Oct 2009 at 12:45
Issue 569 has been merged into this issue.
Original comment by conrad.john
on 14 Nov 2009 at 7:08
Retagged the version number for this issue. This is not a rescheduling, we
are just changing our version number scale.
Original comment by conrad.john
on 29 Nov 2009 at 8:09
[deleted comment]
Hey,
As I'm sharing the Movie Folders with a WDTV Live, having the folder.jpg and
filename.jpg created from the Moving Picture DB would be awesome !
Thanks
Original comment by dlfad...@gmail.com
on 8 Dec 2009 at 7:40
Dlfadolf, what you are asking for is an enhancement request UNRELATED to this
issue. If
you would like to file a new enhancement request, please fell free, but any
further off
topic posts in this issue thread will be deleted.
Original comment by conrad.john
on 9 Dec 2009 at 1:59
[deleted comment]
Attached is an initial release of my idea of how to make this work. Feedback
greatly
appreciated.
-Wrong patch was attached originally. Good to go now.
Original comment by LRFal...@gmail.com
on 12 Dec 2009 at 3:01
Awesome LRFalk, thanks a ton! I will review this ASAP and give you my feedback.
Original comment by conrad.john
on 12 Dec 2009 at 5:37
I have updated some things as well as make some improvements. Undoing a name
change
is now possible.
Original comment by LRFal...@gmail.com
on 13 Dec 2009 at 3:13
Attachments:
Fantastic work LRFalk01. Committed your changes in r1009 (with a few very minor
tweaks
here and there). After we push out 1.0.2 I'll add support for bulk file
renaming
(should eb an easy fix, but we have some critical issues pending for 1.0.2). If
you
have additional changes please create a new patch off the current revision of
the
trunk.
Again, awesome work, thanks a ton!!
Original comment by conrad.john
on 21 Dec 2009 at 6:14
I did a short test with the current version in SVN, basically it works very
good, but
I would like to rename also the foldername of the movie if the foldername was
the one
used for movie indication. (isDedicatedFolder() is the function I think?)
The structure I would like to use would be:
Moviename (year, language)/CD1.avi
but my currenct structure is also that way, so when I use the FileRenamer I get
CurrentMoviename (year, language)/Moviename (year, language)/CD1.avi
expected
Moviename (year, language)/CD1.avi
so foldername was renamed and the filename was well.
thanks!!
Original comment by dominik....@gmail.com
on 14 Jan 2010 at 12:55
concerning the doler renaming the's also the great app from jmcentire:
http://forum.team-mediaportal.com/moving-pictures-284/app-create-rename-folders-
based-info-moving-pictures-76187/
maybe it could help!
I really can't wait to see that app included within Moving picture!
Original comment by giorg...@gmail.com
on 17 Jan 2010 at 9:19
Just wanted to add my point of view.
Renaming the movie files is not a good idea because,
1. Sometime in the future you may realise you need subtitles, so you need to
know the
original rip filename to download the correct subtitles version.
2. Sometime in the future you release that the rip you have is bad quality or
has
errors, unfortunately since you don't have the filename anymore you don't know
which
version you originally downloaded.
A better option is to automatically rename the movie's parent folder if it is
the
only movie in that folder, else if the movie doesn't have it's own folder then
it
creates a subfolder from the movies directory with the movie name, then places
the
movie file in that folder.
Format for foldername should be customizable in the advanced settings, by using
things like %title% %year% %language% etc....
I personally like to have my english movie folder called
\%title% (%year%)\
and if it is a foreign movie
\%english.title% [%foreign.title%] (%year%)\
Original comment by kiwijung...@gmail.com
on 25 Jan 2010 at 10:52
Thanks for the input kiwijunglist.
Currently this logs the original file name in the database, so this information
is
not lost. There is also an option to revert back to the original file name. I
will be
looking into the ability to rename the parent folder's name also.
Original comment by LRFal...@gmail.com
on 25 Jan 2010 at 11:38
Maybe have different options for the rename system?
1. Rename filename only "Movie Title (Year).ext"
2. Rename folder only "Movie Title (Year)"
3. Rename folder and filename "Movie Title (Year)/Movie Title (Year).ext"
Could also perhaps combine it with the NFO system, but then perhaps create like
a
movie_title.ORG.NFO file containing original filename, or make it be a part of
the
movie_title.NFO file.
Don't want to overcomplicate things, but a lot of people have different
preferences.
To throw even more fuel on the fire, I currently use the "Movie Title
[Year].ext"
format, so I can use "Movie Title (Extended) [Year].ext" and "English Title
(Foreign
Title) [Year].ext" combinations and make it easier on some custom RegExp rules.
Original comment by RoChess....@gmail.com
on 26 Jan 2010 at 12:10
RoChess, the file rename system is completely customizable as far as what you
want
the name to be. I agree that it should also have the option to rename the
folder as
well or instead of the file name. It just isn't there yet.
Original comment by LRFal...@gmail.com
on 26 Jan 2010 at 3:44
LRFalk01, I don't think that there is a need for an option to decide if a folder
should be renamed or not. When the movie is in it's own folder
(isDedicatedFolder()
is the function I think) you should anyway rename the folder, otherwise it
doesn't
make any sense for the user to rename all the files inside his movie folders.
Another option would be to get a managed folder structure. The user specifies
the
base path and the folder structure of that one and every new movie gets
automatically
renamed based on the pattern and moved into the base path.
Btw, as kiwijunglist mentioned the original filename, maybe you can add a
pattern for
the original filename, so even his case would be configureable.
Original comment by dominik....@gmail.com
on 26 Jan 2010 at 8:05
I have updated this to also include the ability to rename directories if it is
the
dedicated directory for a movie. Patch attached.
Original comment by LRFal...@gmail.com
on 5 Feb 2010 at 12:44
Attachments:
Thanks very much for the changes LRFalk01. As I mentioned in IRC have been
focusing on
polishing 1.0 right now but will integrate this into the trunk in the next few
days.
Original comment by conrad.john
on 9 Feb 2010 at 5:56
So has this been integrated yet in RC2? Doesn't seem like it :)
Original comment by zinu.to...@gmail.com
on 13 Mar 2010 at 5:11
No, this will be a feature for 1.1.0. v1.0 is code completed.
Original comment by damien.haynes@gmail.com
on 13 Mar 2010 at 10:52
LRFlak01/fforde, I know this is not complete yet but I noticed that FileRenaming
could not be done if you did multiple movie select from Movie Manager. Here is a
patch that addresses that from revision r1085 of trunk:
we can discuss further in IRC.
Original comment by damien.haynes@gmail.com
on 21 Apr 2010 at 2:57
Attachments:
I didn't see that damien already did this, so here is another patch for the same
thing . . .
Original comment by LRFal...@gmail.com
on 21 Apr 2010 at 10:34
Attachments:
new features:
- Rename Preview
- Option to rename folder too
- Other files (like subtitles) with a filename
<MovieFilename>*.<AdditionalFileTypesToRename> will be renamed too
Notes:
- restore folder names is not implemented
- if the new foldername already exist "Rename folder" will not work
- no warning but log entry
new settings:
Additional FileTypes to rename: ".srt|.idx|.sub|.ac3|.dts"
(Filename starts with the MovieFilename + got one of these
Extensions => file will be renamed too)
Rename Folder: "true"
(If true the default value in the RenamePopup for RenameFolder is
'checked')
(If true StartRename() will rename folder by default) (not in
use,renamepopup always sets the value in the Movierenamer Class)
Example.:
File Rename Pattern: ${movie.title} (${movie.year})${moviepart}
Multi-Part Rename Pattern: Part #
1 part, [folder for Subtitles + ac3]
.\Matrix_1part_Subsfolder_ac3\Matrix.avi
.\Matrix_1part_Subsfolder_ac3\Matrix.comment.ac3
.\Matrix_1part_Subsfolder_ac3\Subs\Matrix.English.idx
.\Matrix_1part_Subsfolder_ac3\Subs\Matrix.English.sub
RenameFolder = true :
.\Matrix (1999)\Matrix (1999).avi
.\Matrix (1999)\Matrix (1999).comment.ac3
.\Matrix (1999)\Subs\Matrix (1999).English.idx
.\Matrix (1999)\Subs\Matrix (1999).English.sub
RenameFolder = false :
.\Matrix_1part_Subsfolder_ac3\Matrix (1999).avi
.\Matrix_1part_Subsfolder_ac3\Matrix (1999).comment.ac3
.\Matrix_1part_Subsfolder_ac3\Subs\Matrix (1999).English.idx
.\Matrix_1part_Subsfolder_ac3\Subs\Matrix (1999).English.sub
2 parts, 2 folder, [Subtitles]
.\Matrix_2parts_difffolders\Cd1\Matrix CD1.avi
.\Matrix_2parts_difffolders\Cd1\Matrix CD1.English.srt
.\Matrix_2parts_difffolders\Cd2\Matrix CD2.avi
.\Matrix_2parts_difffolders\Cd2\Matrix CD2.English.srt
RenameFolder = true :
(dont know if this is a good solution...)
.\Matrix_2parts_difffolders\Matrix (1999) Part 1\Matrix (1999) Part
1.avi
.\Matrix_2parts_difffolders\Matrix (1999) Part 1\Matrix (1999) Part
1.English.srt
.\Matrix_2parts_difffolders\Matrix (1999) Part 2\Matrix (1999) Part
2.avi
.\Matrix_2parts_difffolders\Matrix (1999) Part 2\Matrix (1999) Part
2.English.srt
RenameFolder = false :
.\Matrix_2parts_difffolders\Cd1\Matrix (1999) Part 1.avi
.\Matrix_2parts_difffolders\Cd1\Matrix (1999) Part 1.English.srt
.\Matrix_2parts_difffolders\Cd2\Matrix (1999) Part 2.avi
.\Matrix_2parts_difffolders\Cd2\Matrix (1999) Part 2.English.srt
2 parts same folder, [Subtiltes]
.\Matrix_2parts_samefolders\Matrix CD1.avi
.\Matrix_2parts_samefolders\Matrix CD1.English.srt
.\Matrix_2parts_samefolders\Matrix CD2.avi
.\Matrix_2parts_samefolders\Matrix CD2.English.srt
RenameFolder = true :
.\Matrix (1999)\Matrix (1999) Part 1.avi
.\Matrix (1999)\Matrix (1999) Part 1.English.srt
.\Matrix (1999)\Matrix (1999) Part 2.avi
.\Matrix (1999)\Matrix (1999) Part 2.English.srt
RenameFolder = false :
.\Matrix_2parts_samefolders\Matrix (1999) Part 1.avi
.\Matrix_2parts_samefolders\Matrix (1999) Part 1.English.srt
.\Matrix_2parts_samefolders\Matrix (1999) Part 2.avi
.\Matrix_2parts_samefolders\Matrix (1999) Part 2.English.srt
Bug:
Rename Folder on + old_foldername < new_foldername => Wrong DB
entry in FullPath
eg.: .\M\Matrix.avi -> .\Matrix(1999)atrix (1999)\Matrix(1999).avi
instead of .\Matrix(1999)\Matrix(1999).avi
after reopen Configuration the right Path is set.
First there is the right path in the DB, but AFTER StartRename() is
finished there is the wrong path.
Original comment by onkeldag...@googlemail.com
on 5 Jun 2010 at 6:46
Attachments:
Onkel, is this patch an expansion of the existing rename functionality already
implemented?
Original comment by conrad.john
on 5 Jun 2010 at 9:11
yes
Original comment by onkeldag...@googlemail.com
on 5 Jun 2010 at 10:58
Ok there is the patch again....
+bug fixed
+added option to rename only folders
Original comment by onkeldag...@googlemail.com
on 8 Jun 2010 at 4:23
Attachments:
Okay just committed several updates to the renaming system in r1121. Click the
revision number there for details.
Onkel I just want to say thanks a ton for your patch. I didn't use everything
(I redid the Approval Popup) and I did some pretty major refactoring (the
renamer itself) but your changes definitely saved me at *least* a few days
worth of work.
For anyone compiling yourself, from the trunk, I'd definitely love some
feedback. please keep in mind though that this feature is still new and has had
limited testing. For the love of god, back up your database! And at least at
first, please be sure to review all renames (the default), because you never
know if we have some undiscovered bug hidden in there.
Original comment by conrad.john
on 2 Jul 2010 at 5:52
- GetSecondaryFiles() and Revert() should include files like
"Moviename.English.srt" and search in Subfolders (like ./Subs/) too.
(see 1121_GetSecondaryFiles_Revert.patch)
- Bug: ( movingpictures_dirfilesbug.log )
Rename Folder and Files (2 movieparts)
-> only new foldername is set in DB. Filenames are still the same or only one is changed.
reason: MovieImporter.OnFileRename() for a moviepart is called AFTER the folder was renamed -> OnFileRename cant find new filename -> return without changes
Original comment by onkeldag...@googlemail.com
on 2 Jul 2010 at 4:30
Attachments:
Thanks Onkel, I will try to look at these items tonight. I have some family
coming in town today though so if it takes a few days, I apologize in advance.
;)
Did you have any thoughts on the usability and workflow side of things?
Original comment by conrad.john
on 2 Jul 2010 at 4:38
I haven't been able to test these patches yet, but please be aware of the
following situation:
Movie.avi
Movie.srt (forced subs for alian/foreign bits)
Movie.Full.srt (or Movie-Full.srt)
Movie.DirCut.srt (or Movie-Director's Comment.srt)
All those other files have to be renamed properly as well to not break the
function of allowing MediaPortal to select between the different subtitle
options.
Original comment by RoChess....@gmail.com
on 2 Jul 2010 at 4:43
Issue 876 has been merged into this issue.
Original comment by conrad.john
on 24 Aug 2010 at 1:07
fforde, do you think 'Original Directory Name' should be removed from Movie
Details screen in configuration? Or atleast moved to 'File Details' section.
Original comment by damien.haynes@gmail.com
on 20 Sep 2010 at 8:36
Issue 898 has been merged into this issue.
Original comment by conrad.john
on 28 Oct 2010 at 4:07
Original comment by conrad.john
on 31 Jan 2011 at 1:22
Original comment by conrad.john
on 8 Aug 2011 at 8:11
Hi,
I love the rename feature in movpic. Thanks for the great work.
One thing I am missing is the possibility to use file infos like video
resolution ${movie.videoresolution} for the rename pattern.
Possible to add that?
Thanks
Michael
Original comment by michael....@gmail.com
on 7 Aug 2012 at 11:33
Original issue reported on code.google.com by
luksm...@gmail.com
on 6 Dec 2008 at 4:13