Totally fine if you want to reject this but I was looking at the VCU code-base to see where things were at and me and my code linter (cppcheck) kept spotting minor problems. So I did a bit of tidying as I went.
There were various bits of non-obvious dead code highlighted. The linker probably removed a lot of this but it made it difficult to understand. I've left all of the commented out code as that looks to be WIP/documentation which is of value.
I found a few data tables which could be marked constant so they can stay in flash without causing any detriment.
There should be no function affecting changes which should break anything. I worked on the principle if compilation can't prove correctness I wasn't going to touch it.
Totally fine if you want to reject this but I was looking at the VCU code-base to see where things were at and me and my code linter (cppcheck) kept spotting minor problems. So I did a bit of tidying as I went.
There were various bits of non-obvious dead code highlighted. The linker probably removed a lot of this but it made it difficult to understand. I've left all of the commented out code as that looks to be WIP/documentation which is of value.
I found a few data tables which could be marked constant so they can stay in flash without causing any detriment.
There should be no function affecting changes which should break anything. I worked on the principle if compilation can't prove correctness I wasn't going to touch it.