client::new() and client::send_message() return Result instead of panic

damienpontifex / azure-iot-sdk-rs

A rust library for connecting devices to Microsoft Azure IoT Hub

MIT License

14 stars 11 forks source link

client::new() and client::send_message() return Result instead of panic #33

Closed rubberduck203 closed 4 years ago

rubberduck203 commented 4 years ago

Begins work on #6 This works for my purposes and needs, but I wanted to start a conversation on the approach.

damienpontifex commented 4 years ago

@rubberduck203 could you rebase this from master? I just removed cargo audit from the CI build as it was timing out causing the workflow to be cancelled

rubberduck203 commented 4 years ago

@damienpontifex rebased. Thanks. I left a few comments I'd like your thoughts on. Also, do you need the whole API redone in order to merge this in or are you ok with temporarily being a bit inconsistent?

damienpontifex commented 4 years ago

Thanks @rubberduck203 I'm happy to break it up and add useful errors piecewise. So happy for this as a great start and something to build off for error handling. Would you be happy for me to merge? Or any other changes you'd like to make before that?

rubberduck203 commented 4 years ago

@damienpontifex this meets my needs for the moment. I would be happy with this being merged.