Notifications at the bottom of the window are not showing up in 5.6.23+

damiensellier commented 3 weeks ago

Due to JUCE updates, the notify() is no longer available to display notification overlays at the bottom of the window.

notify()

We need to find where the notify() function was implemented and backtrace it to make it work again. OR If not possible because of the outdated JUCE class, notifications should be displayed in the menu bar next to title for a short while as a workaround.

NOTE :

Source/Core/CtrlrPanel/CtrlrPanelFileOperations.cpp

Source/Core/CtrlrPanel/CtrlrPanel.cpp LINE 1702

void CtrlrPanel::notify (const String &notification, CtrlrNotificationCallback *callback, const CtrlrNotificationType ctrlrNotificationType)
{
    if (luaPanelMessageHandlerCbk && !luaPanelMessageHandlerCbk.wasObjectDeleted())
    {
        if (luaPanelMessageHandlerCbk->isValid())
        {
            getCtrlrLuaManager().getMethodManager().call (luaPanelMessageHandlerCbk, notification, ctrlrNotificationType);
        }
    }

    _INF (notification);
}

damiensellier commented 2 weeks ago

5.3.198 has extra GUI code for notification bar overlay compared to 5.6.23+ :

Source/UIComponents/CtrlrPanel/CtrlrPanelEditor.cpp LINE 14

CtrlrPanelNotifier::CtrlrPanelNotifier(CtrlrPanelEditor &_owner)
    : owner(_owner), background(Colours::lightgrey)
{
    addAndMakeVisible (text = new Label());
    text->addMouseListener (this,true);
    text->setColour (Label::backgroundColourId, Colours::transparentBlack);
    text->setColour (Label::textColourId, Colours::white.withAlpha (0.85f));
    text->setFont (Font (12.0f, Font::bold));
}

void CtrlrPanelNotifier::paint (Graphics &g)
{
    drawSelectionRectangle (g, getWidth(), getHeight(), background);
}

void CtrlrPanelNotifier::resized()
{
    text->setBounds (16,0,getWidth()-32,getHeight());
}

void CtrlrPanelNotifier::setNotification (const String &notification, const CtrlrNotificationType ctrlrNotificationType)
{
    background = getBackgroundColourForNotification(ctrlrNotificationType);
    text->setText (notification, dontSendNotification);
}

void CtrlrPanelNotifier::mouseDown (const MouseEvent &e)
{
    owner.notificationClicked(e);
}

Colour CtrlrPanelNotifier::getBackgroundColourForNotification(const CtrlrNotificationType ctrlrNotificationType)
{
    switch (ctrlrNotificationType)
    {
        case NotifySuccess:
            return (Colours::green.brighter(0.2f));
        case NotifyFailure:
            return (Colours::red.brighter(0.2f));
        case NotifyWarning:
            return (Colours::yellow.darker(0.5f));
        case NotifyInformation:
            return (Colours::grey);
    }

    return (Colours::lightgrey);
}

CtrlrPanelEditor.h declaration to add back :

class CtrlrPanelNotifier : public Component  // Added back v5.6.31
{
    public:
        CtrlrPanelNotifier(CtrlrPanelEditor &_owner);
        ~CtrlrPanelNotifier() {}
        void paint (Graphics &g);
        void resized();
        void setNotification (const String &notification, const CtrlrNotificationType ctrlrNotificationType);
        Colour getBackgroundColourForNotification(const CtrlrNotificationType ctrlrNotificationType);
        void mouseDown (const MouseEvent &e);

        JUCE_LEAK_DETECTOR(CtrlrPanelNotifier)

    private:
        Colour background;
        ScopedPointer <Label> text;
        CtrlrPanelEditor &owner;
};

class CtrlrPanelEditor ...

    public:
        void notify(const String &notification, CtrlrNotificationCallback *callback, const CtrlrNotificationType ctrlrNotificationType = NotifyInformation); // Added back v5.6.31
        void notificationClicked(const MouseEvent e); // Added back v5.6.31
        void changeListenerCallback (ChangeBroadcaster *source); // Added back v5.6.31

    private:
        ScopedPointer <CtrlrPanelNotifier> ctrlrPanelNotifier; // Added back v5.6.31

damiensellier commented 2 weeks ago

Core/CtrlrPanel/CtrlrPanel.cpp LINE 1702

void CtrlrPanel::notify (const String &notification, CtrlrNotificationCallback *callback, const CtrlrNotificationType ctrlrNotificationType)
{
    if (luaPanelMessageHandlerCbk && !luaPanelMessageHandlerCbk.wasObjectDeleted())
    {
        if (luaPanelMessageHandlerCbk->isValid())
        {
            getCtrlrLuaManager().getMethodManager().call (luaPanelMessageHandlerCbk, notification, ctrlrNotificationType);
        }
    }

    if (getEditor()) // Added back v5.6.31
    {
        getEditor()->notify (notification, callback, ctrlrNotificationType);
    }
    else
    {
        _INF (notification);
    }
    // _INF (notification);
}

damiensellier commented 2 weeks ago

CtrlrPanelNotifier::CtrlrPanelNotifier(CtrlrPanelEditor &_owner) // Added back v5.6.31
    : owner(_owner), background(Colours::lightgrey)
{
    addAndMakeVisible (text = new Label());
    text->addMouseListener (this, true);
    text->setColour (Label::backgroundColourId, Colours::transparentBlack);
    text->setColour (Label::textColourId, Colours::black.withAlpha (0.85f));
    text->setColour (Label::outlineColourId, Colours::transparentBlack);
    text->setFont (Font (12.0f, Font::bold));
    text->setText ("Default Footer Notification", dontSendNotification); // Default or empty text required
}

damiensellier commented 2 weeks ago

Here we go, the notification bottom overlay for file operations is back :

notify-ovelay-back

dobo365 commented 4 days ago

I'm getting an error with drawSelectionRectangle not found. Where is it defined? I'm searching in 5.3.201...